Skip to content

Conversation

@richlander
Copy link
Member

No description provided.

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 15, 2024
@lewing lewing requested review from akoeplinger and directhex April 15, 2024 21:28
@richlander
Copy link
Member Author

Looks like HttpClient is failing on CentOS Stream 9.

FYI: https://blog.centos.org/2023/04/end-dates-are-coming-for-centos-stream-8-and-centos-linux-7/

@dotnet/ncl

@wfurt
Copy link
Member

wfurt commented Apr 16, 2024

seems like msquic is missing in the images. I do see packages published https://packages.microsoft.com/rhel/9/prod/Packages/l/
I think the fix should come from the prerequisites repo @richlander

@wfurt
Copy link
Member

wfurt commented Apr 17, 2024

it seems like the test runs are clean @richlander

@richlander
Copy link
Member Author

richlander commented Apr 17, 2024

Thanks for the help!

We still need the correct label to be applied. I don't know what that is.

@wfurt wfurt added area-Infrastructure Servicing-approved Approved for servicing release test-enhancement Improvements of test source code and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 17, 2024
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@wfurt
Copy link
Member

wfurt commented Apr 17, 2024

this is test only change. It should be OK to just merge it right @carlossanlop ?

@richlander
Copy link
Member Author

I just realized I edited some files in the common folder. Those changes should be removed, right?

@wfurt
Copy link
Member

wfurt commented Apr 17, 2024

I don't know.
There is IMHO difference between eng/pipelines/common/ and eng/common. First probably belongs to runtime, second belongs to arcade. @akoeplinger or @ViktorHofer would probably know for sure.

@richlander
Copy link
Member Author

Ah. You may well be right. We'll wait for the experts to weigh in.

@ViktorHofer
Copy link
Member

ViktorHofer commented Apr 18, 2024

Correct, /eng/common changes must be done in Arcade. I don't see any of those in this PR though so you should be good.

@richlander
Copy link
Member Author

Can you review @carlossanlop and/or @hoyosjs ?

Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@richlander richlander merged commit 11c5492 into dotnet:release/8.0-staging Apr 24, 2024
@richlander richlander deleted the eol-versions-8.0 branch April 24, 2024 15:54
@richlander
Copy link
Member Author

Thanks for the help everyone!

@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure Servicing-approved Approved for servicing release test-enhancement Improvements of test source code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants