[release/8.0-staging] [wasm] Fix AOT publish in paths with space on Windows/Linux #101109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ilonatommy
added
Servicing-consider
ilonatommy
requested review from
lewing,
maraf and
radekdoulik
and removed request for
radical
ilonatommy
added
Servicing-approved
ilonatommy
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #94166 and #94306 to release/8.0-staging
/cc @ilonatommy
Customer Impact
Fixes #101055. Publishing AOT project that has spaces in path fails on multiple platforms. The issue was fixed for net9 in PRs: dotnet/emsdk#611, #94166, #94306.
Emsdkchange was backported but the runtime changes are missing in net8.Regression
Testing
There's a WBT test added to the PR.
Risk
Low, it encloses paths/property values in quotations.