Skip to content

Conversation

@eduardo-vp
Copy link
Member

@eduardo-vp eduardo-vp commented Apr 19, 2024

This work is a continuation of #100994, the whole task being making the release/8.0-staging branch transition to the official 1ES templates.

Both PRs (#91646 and #91708) consist of fairly simple changes (additions mostly) so should be a low risk PR.

Official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2436370&view=results

CC @amanasifkhalid

@ghost
Copy link

ghost commented Apr 19, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@eduardo-vp eduardo-vp changed the base branch from main to release/8.0-staging April 19, 2024 21:02
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

…#91708)

* Tweak invocations, disable service updates, detect vswhere missing
* Try disabling update early in build
* Only collect logs on official build on exit
@eduardo-vp eduardo-vp closed this Apr 23, 2024
@eduardo-vp eduardo-vp reopened this Apr 23, 2024
@eduardo-vp eduardo-vp changed the title [Testing] Merge #91646 into release/8.0-staging Merge #91646 and #91708 into release/8.0-staging Apr 23, 2024
@eduardo-vp eduardo-vp marked this pull request as ready for review April 23, 2024 15:27
@eduardo-vp eduardo-vp added the Servicing-consider Issue for next servicing release review label Apr 23, 2024
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. please get a code review and we can merge as tell mode.

@jeffschwMSFT jeffschwMSFT removed the Servicing-consider Issue for next servicing release review label Apr 23, 2024
@jeffschwMSFT jeffschwMSFT added this to the 8.0.x milestone Apr 23, 2024
@eduardo-vp eduardo-vp added the Servicing-approved Approved for servicing release label Apr 25, 2024
@eduardo-vp eduardo-vp merged commit 845cd4f into dotnet:release/8.0-staging Apr 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
@eduardo-vp eduardo-vp deleted the release/8.0-staging branch May 29, 2024 20:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants