Fix big endian issue in Interlocked test cases #101429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix big indian issue wiht BitConverted as part of intercloked test cases.
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @mangod9 |
|
/azp run runtime-community |
|
Commenter does not have sufficient privileges for PR 101429 in repo dotnet/runtime |
jkotas
reviewed
Apr 23, 2024
src/libraries/System.Private.CoreLib/src/System/Threading/Interlocked.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Threading/Interlocked.cs
Outdated
Show resolved
Hide resolved
Fix big indian issue wiht BitConverted as part of intercloked test cases. These were causing failures in runtime_community pipeline
This was referenced Apr 23, 2024
Closed
|
@akoeplinger , can you run "runtime community" pipeline on this. Lets see if the fix holds good for System.Threads.tests failures seen as part of #101380 |
|
/azp run runtime-community |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@akoeplinger Thanks for initiating the run. |
akoeplinger
approved these changes
Apr 25, 2024
|
/ba-g failures are not related, this change only affects big endian platforms |
Yep, I'm doing it in #101527 so that we don't need to restart CI if it doesn't. |
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
Fix big indian issue wiht BitConverted as part of intercloked test cases. These were causing failures in runtime_community pipeline --------- Co-authored-by: root <[email protected]>
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
Fix big indian issue wiht BitConverted as part of intercloked test cases. These were causing failures in runtime_community pipeline --------- Co-authored-by: root <[email protected]>
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
Fix big indian issue wiht BitConverted as part of intercloked test cases. These were causing failures in runtime_community pipeline --------- Co-authored-by: root <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix big indian issue wiht BitConverted as part of intercloked test cases.
These were causing failures in runtime_community pipeline