Skip to content

Conversation

@eduardo-vp
Copy link
Member

@eduardo-vp eduardo-vp commented Apr 25, 2024

This is part of the work to transition to the 1ES templates.

These PRs are relatively small and could be cherry-picked without any conflict, they will allow to almost cleanly backport #92296.

Official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2438904&view=results

cc @agocke @jkoritzinsky @amanasifkhalid

elinor-fung and others added 3 commits April 25, 2024 15:59
- Run tests in in installer pipeline on Linux_x64 even though it is cross-build. 
- Fix uploading of binaries/symbols on failure
Avoids errors like "Artifact Installer-Logs-coreclr--windows_arm64-Debug already exists for build 1636423." when retrying jobs.
* Separate running PAL tests out to their own jobs/steps.

* Remove PAL tests running infra from the CoreCLR build job and the runtime tests templates.

* !drop Strip out all jobs from runtime.yml and replace with the new PAL tests job to make it easier to test

* Remove dependency on EvaluatePaths

* Reparent job parameters correctly.

* Add back EvaluatePaths step for simplicity

* Set missing properties

* Capitalize build config

* Make a tarball to preserve permission bits.

* Make the output path directory before trying to use it

* Double timeout

* Double timeout again. Looks like Mac needs it.

* Fix metadata name and put back to 10 minutes.

* Move changes to the correct pipeline and revert changes to runtime.yml

* Remove reference to deleted target
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 25, 2024
@eduardo-vp eduardo-vp changed the title [Testing] Backport #91643 release/8.0-staging [Testing] Backport #89953, #91658 and #91643 to release/8.0-staging Apr 26, 2024
@eduardo-vp eduardo-vp added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 26, 2024
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@eduardo-vp eduardo-vp marked this pull request as ready for review April 26, 2024 05:40
@eduardo-vp eduardo-vp changed the title [Testing] Backport #89953, #91658 and #91643 to release/8.0-staging Backport #89953, #91658 and #91643 to release/8.0-staging Apr 26, 2024
@eduardo-vp eduardo-vp added the Servicing-consider Issue for next servicing release review label Apr 26, 2024
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we can take this change as tell mode

cc @carlossanlop and @ericstj

@eduardo-vp eduardo-vp added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 28, 2024
@eduardo-vp eduardo-vp merged commit b86ccd0 into dotnet:release/8.0-staging Apr 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
@eduardo-vp eduardo-vp deleted the backport-91643-release-8.0-staging branch May 29, 2024 20:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants