[NativeAOT] Remove `linux-arm` as a supported RID in .NET8 #102072

ivanpovazan · 2024-05-10T09:54:16Z

Customer Impact

Customer reported
Found internally

In .NET8 linux-arm is incorrectly listed as the officially supported RID with NativeAOT:

runtime/src/installer/pkg/projects/Microsoft.DotNet.ILCompiler/ILCompilerRIDs.props

Line 5 in 8966d08

which can cause build failures during project Restore as NuGet will not be able to find the required runtime package.

IMPORTANT: This does not impact .NET9 as we now do have support for linux-arm.

The customer issue - mobile scenario

In #100929 customer reported build failures when trying out NativeAOT deployments with their MAUI apps targeting iOS platforms with .NET8 from Visual Studio.

The project build fails during the Restore target with the following error:

_Unable to find a stable package runtime.linux-arm.Microsoft.DotNet.ILCompiler with version (>= 8.0.3)

Found 3 version(s) in nuget.org [ Nearest version: 9.0.0-preview.1.24080.9 ]
Found 0 version(s) in /usr/local/share/dotnet/library-packs_

The internal find - desktop scenario

The same issue can occur with the following set up:

Project file:

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFrameworks>net9.0;net8.0</TargetFrameworks>
    <RuntimeIdentifiers>linux-x64;linux-arm</RuntimeIdentifiers>
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>
    <PublishAot>true</PublishAot>
  </PropertyGroup>

</Project>

Build with:

dotnet publish -f net8.0

Fails with:

/workspaces/tmp/naot.csproj : error NU1103: Unable to find a stable package runtime.linux-arm.Microsoft.DotNet.ILCompiler with version (>= 8.0.2)
/workspaces/tmp/naot.csproj : error NU1103:   - Found 3 version(s) in nuget.org [ Nearest version: 9.0.0-preview.1.24080.9 ]

Regression

Yes
No

As @MichalStrehovsky noted this seems to be a left over from: dotnet/runtimelab#1530 and was not discovered until now.

Testing

Manually verified that by removing the linux-arm entry from: ~/.nuget/packages/microsoft.dotnet.ilcompiler/8.0.2/runtime.json which is a file generated from ILCompilerRIDs.props fixes the issue and the project builds properly.

Risk

Low.

Fixes #100929

dotnet-policy-service · 2024-05-10T09:54:37Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

ivanpovazan · 2024-05-10T09:54:48Z

/cc: @simonrozsival

jkotas

I do not think that this is the right fix

jkotas · 2024-05-10T14:49:16Z

src/installer/pkg/projects/Microsoft.DotNet.ILCompiler/ILCompilerRIDs.props

  <ItemGroup>
    <!-- The officially-supported subset of these RIDs should be included in ILCompilerSupportedRids in
         https://github.com/dotnet/installer/blob/main/src/redist/targets/GenerateBundledVersions.targets -->
-    <OfficialBuildRID Include="linux-arm" Platform="arm" />


This lists all packages that may possibly exists.

linux-arm is not the only package that is not officially shipping. freebsd later in this list is not officially shipping either.

I think the key here is that nobody will have freebsd in their RuntimeIdentifiers because nothing will restore with that in the RuntimeIdentifiers list (even if we take native AOT out of the picture completely, like I did in the below):

<Project Sdk="Microsoft.NET.Sdk"> <PropertyGroup> <OutputType>Exe</OutputType> <RuntimeIdentifiers>win-x64;freebsd-x64</RuntimeIdentifiers> <TargetFramework>net8.0</TargetFramework> <SelfContained>true</SelfContained> </PropertyGroup> </Project>

Running dotnet publish on this:

D:\restoreerror>dotnet publish -bl D:\restoreerror\restoreerror.csproj : error NU1101: Unable to find package Microsoft.NETCore.App.Runtime.freebsd-x64. No packages exist with this id in source(s): C:\Program Files\dotnet\library-packs, Microsoft Visual Studio Offline Packages, NET8, nuget.org D:\restoreerror\restoreerror.csproj : error NU1101: Unable to find package Microsoft.AspNetCore.App.Runtime.freebsd-x64. No packages exist with this id in source(s): C:\Program Files\dotnet\library-packs, Microsoft Visual Studio Offline Packages, NET8, nuget.org D:\restoreerror\restoreerror.csproj : error NU1101: Unable to find package Microsoft.NETCore.App.Host.freebsd-x64. No packages exist with this id in source(s): C:\Program Files\dotnet\library-packs, Microsoft Visual Studio Offline Packages, NET8, nuget.org Restore failed with 3 error(s) in 1.4s

Now if we put native AOT back in the picture and try with a RID that is properly annotated as non-existent:

<Project Sdk="Microsoft.NET.Sdk"> <PropertyGroup> <OutputType>Exe</OutputType> <RuntimeIdentifiers>win-x64;win-x86</RuntimeIdentifiers> <TargetFramework>net8.0</TargetFramework> <PublishAot>true</PublishAot> </PropertyGroup> </Project>

Try that:

D:\restoreerror>dotnet publish -bl Restore complete (0.5s) You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy restoreerror succeeded (3.4s) → bin\Release\net8.0\win-x64\publish\ Build succeeded in 4.1s

Note this succeeded even though win-x86 doesn't work in .NET 8.

And now try with the bad one that is getting addressed here;

<Project Sdk="Microsoft.NET.Sdk"> <PropertyGroup> <OutputType>Exe</OutputType> <RuntimeIdentifiers>win-x64;linux-arm</RuntimeIdentifiers> <TargetFramework>net8.0</TargetFramework> <PublishAot>true</PublishAot> </PropertyGroup> </Project>

This results in:

D:\restoreerror>dotnet publish -bl D:\restoreerror\restoreerror.csproj : error NU1103: Unable to find a stable package runtime.linux-arm.Microsoft.DotNet.ILCompiler with version (>= 8.0.2) - Found 3 version(s) in nuget.org [ Nearest version: 9.0.0-preview.1.24080.9 ] - Found 0 version(s) in Microsoft Visual Studio Offline Packages - Found 0 version(s) in C:\Program Files\dotnet\library-packs - Found 0 version(s) in NET8 Restore failed with 1 error(s) in 1.6s

I think this fix is good and complete given NuGet's odd behaviors (I don't get why it needs to restore RIDs we're not building, but this behavior is not native AOT specific).

Thank you both.
I will investigate this further.

NuGet's odd behaviors (I don't get why it needs to restore RIDs we're not building

Isn't the whole purpose of RuntimeIdentifiers to tell NuGet the list of RIDs that you plan to build for, so that you can run a single restore and then build for multiple RIDs without redoing the restore?

FWIW the presence of runtime.json makes NuGet Restore try to merge runtimes defined for Microsoft.DotNet.ILCompiler which I think causes the restore to fail (notice the: Merging in runtimes defined in package/Microsoft.DotNet.ILCompiler 8.0.2.).

For project:

<PropertyGroup> <OutputType>Exe</OutputType> <TargetFramework>net8.0</TargetFramework> <RuntimeIdentifiers>osx-arm64;linux-arm</RuntimeIdentifiers> <ImplicitUsings>enable</ImplicitUsings> <Nullable>enable</Nullable> <PublishAot>true</PublishAot> </PropertyGroup>

Built with: dotnet publish

Restoring packages for /Users/ivan/tmp/naot_rids/naot_rids.csproj... Restoring packages for .NETCoreApp,Version=v8.0... Resolving conflicts for net8.0... Scanning packages for runtime.json files... Merging in runtimes defined in package/Microsoft.DotNet.ILCompiler 8.0.2. Restoring packages for net8.0/linux-arm... Restoring packages for net8.0/osx-arm64... Resolving conflicts for net8.0/osx-arm64... Assembly loaded during TaskRun (NuGet.Build.Tasks.RestoreTask): System.Security.Cryptography.Algorithms, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a (location: /usr/local/share/dotnet/shared/Microsoft.NETCore.App/9.0.0-preview.3.24172.9/System.Security.Cryptography.Algorithms.dll, MVID: 01b05f88-ddd1-481c-a82c-7cf815ec6308, AssemblyLoadContext: Default) Assembly loaded during TaskRun (NuGet.Build.Tasks.RestoreTask): System.Security.Cryptography.Primitives, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a (location: /usr/local/share/dotnet/shared/Microsoft.NETCore.App/9.0.0-preview.3.24172.9/System.Security.Cryptography.Primitives.dll, MVID: 5969dcae-99a3-40d5-9227-3330c81a8815, AssemblyLoadContext: Default) Assembly loaded during TaskRun (NuGet.Build.Tasks.RestoreTask): System.Runtime.Serialization.Formatters, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a (location: /usr/local/share/dotnet/shared/Microsoft.NETCore.App/9.0.0-preview.3.24172.9/System.Runtime.Serialization.Formatters.dll, MVID: 4014afb0-9078-4651-b39d-7ba50fba2edc, AssemblyLoadContext: Default) Assembly loaded during TaskRun (NuGet.Build.Tasks.RestoreTask): System.Diagnostics.TraceSource, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a (location: /usr/local/share/dotnet/shared/Microsoft.NETCore.App/9.0.0-preview.3.24172.9/System.Diagnostics.TraceSource.dll, MVID: e641c01b-b934-4762-b8e0-c746319635ff, AssemblyLoadContext: Default) Assembly loaded during TaskRun (NuGet.Build.Tasks.RestoreTask): System.Data.Common, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a (location: /usr/local/share/dotnet/shared/Microsoft.NETCore.App/9.0.0-preview.3.24172.9/System.Data.Common.dll, MVID: 7f8f6503-7ea7-4c77-84de-bcde27273caa, AssemblyLoadContext: Default) Assembly loaded during TaskRun (NuGet.Build.Tasks.RestoreTask): System.ComponentModel, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a (location: /usr/local/share/dotnet/shared/Microsoft.NETCore.App/9.0.0-preview.3.24172.9/System.ComponentModel.dll, MVID: e92d0acc-26bc-4c82-85da-ffa2f4743b9c, AssemblyLoadContext: Default) Assembly loaded during TaskRun (NuGet.Build.Tasks.RestoreTask): Anonymously Hosted DynamicMethods Assembly, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null (location: , MVID: d6dae581-dca2-42b0-8b60-c45bb1b744cf, AssemblyLoadContext: Default) CACHE https://api.nuget.org/v3-flatcontainer/runtime.linux-arm.microsoft.dotnet.ilcompiler/index.json Resolving conflicts for net8.0/linux-arm... 1>/Users/ivan/tmp/naot_rids/naot_rids.csproj : error NU1103: Unable to find a stable package runtime.linux-arm.Microsoft.DotNet.ILCompiler with version (>= 8.0.2) /Users/ivan/tmp/naot_rids/naot_rids.csproj : error NU1103: - Found 3 version(s) in nuget.org [ Nearest version: 9.0.0-preview.1.24080.9 ] /Users/ivan/tmp/naot_rids/naot_rids.csproj : error NU1103: - Found 0 version(s) in /usr/local/share/dotnet/library-packs

while when I remove the entry for linux-arm (or completely remove runtime.json) the restore succeeds.

Restoring packages for .NETCoreApp,Version=v8.0... Resolving conflicts for net8.0... Scanning packages for runtime.json files... Restoring packages for net8.0/linux-arm... Resolving conflicts for net8.0/linux-arm... Restoring packages for net8.0/osx-arm64... Resolving conflicts for net8.0/osx-arm64... Assembly loaded during TaskRun (NuGet.Build.Tasks.RestoreTask): System.Net.Http, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a (location: /usr/local/share/dotnet/shared/Microsoft.NETCore.App/9.0.0-preview.3.24172.9/System.Net.Http.dll, MVID: d15a0545-b86a-46a0-841b-8f1dd4433417, AssemblyLoadContext: Default) Assembly loaded during TaskRun (NuGet.Build.Tasks.RestoreTask): System.Security.Cryptography.Algorithms, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a (location: /usr/local/share/dotnet/shared/Microsoft.NETCore.App/9.0.0-preview.3.24172.9/System.Security.Cryptography.Algorithms.dll, MVID: 01b05f88-ddd1-481c-a82c-7cf815ec6308, AssemblyLoadContext: Default) Assembly loaded during TaskRun (NuGet.Build.Tasks.RestoreTask): System.Security.Cryptography.Primitives, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a (location: /usr/local/share/dotnet/shared/Microsoft.NETCore.App/9.0.0-preview.3.24172.9/System.Security.Cryptography.Primitives.dll, MVID: 5969dcae-99a3-40d5-9227-3330c81a8815, AssemblyLoadContext: Default) CACHE https://api.nuget.org/v3/vulnerabilities/index.json Assembly loaded during TaskRun (NuGet.Build.Tasks.RestoreTask): System.Runtime.Serialization.Formatters, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a (location: /usr/local/share/dotnet/shared/Microsoft.NETCore.App/9.0.0-preview.3.24172.9/System.Runtime.Serialization.Formatters.dll, MVID: 4014afb0-9078-4651-b39d-7ba50fba2edc, AssemblyLoadContext: Default) Assembly loaded during TaskRun (NuGet.Build.Tasks.RestoreTask): System.Text.Encodings.Web, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 (location: /usr/local/share/dotnet/shared/Microsoft.NETCore.App/9.0.0-preview.3.24172.9/System.Text.Encodings.Web.dll, MVID: 9fc1299c-c5e0-4fa8-9504-79550313bec2, AssemblyLoadContext: Default) Assembly loaded during TaskRun (NuGet.Build.Tasks.RestoreTask): System.Runtime.Intrinsics, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 (location: /usr/local/share/dotnet/shared/Microsoft.NETCore.App/9.0.0-preview.3.24172.9/System.Runtime.Intrinsics.dll, MVID: 8bbeaa60-2722-4527-be01-8b072b37ce67, AssemblyLoadContext: Default) CACHE https://api.nuget.org/v3-vulnerabilities/2024.05.11.01.16.50/vulnerability.base.json CACHE https://api.nuget.org/v3-vulnerabilities/2024.05.11.01.16.50/2024.05.13.07.16.55/vulnerability.update.json Assembly loaded during TaskRun (NuGet.Build.Tasks.RestoreTask): System.Diagnostics.TraceSource, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a (location: /usr/local/share/dotnet/shared/Microsoft.NETCore.App/9.0.0-preview.3.24172.9/System.Diagnostics.TraceSource.dll, MVID: e641c01b-b934-4762-b8e0-c746319635ff, AssemblyLoadContext: Default) Assembly loaded during TaskRun (NuGet.Build.Tasks.RestoreTask): System.Data.Common, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a (location: /usr/local/share/dotnet/shared/Microsoft.NETCore.App/9.0.0-preview.3.24172.9/System.Data.Common.dll, MVID: 7f8f6503-7ea7-4c77-84de-bcde27273caa, AssemblyLoadContext: Default) Assembly loaded during TaskRun (NuGet.Build.Tasks.RestoreTask): System.ComponentModel, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a (location: /usr/local/share/dotnet/shared/Microsoft.NETCore.App/9.0.0-preview.3.24172.9/System.ComponentModel.dll, MVID: e92d0acc-26bc-4c82-85da-ffa2f4743b9c, AssemblyLoadContext: Default) All packages and projects are compatible with net8.0. All packages and projects are compatible with net8.0 (linux-arm). All packages and projects are compatible with net8.0 (osx-arm64). Committing restore...

This happens somewhere around: https://github.com/NuGet/NuGet.Client/blob/78c8c0fddd17dbf23e110c44ea1455f49e50363f/src/NuGet.Core/NuGet.Commands/RestoreCommand/ProjectRestoreCommand.cs#L458 and I am not super familiar with the code, but I suppose the build should probably bail out earlier than this.

agocke · 2024-05-10T17:07:54Z

I believe we've hit this before with PublishAot in a project file that contains TFMs that don't support AOT, like

<PropertyGroup>
  <TargetFrameworks>net8.0;net6.0</TargetFrameworks>
  <PublishAot>true</PublishAot>
</PropertyGroup>

My recollection is that we suggested users condition the PublishAot property to fix this, i.e.

<PropertyGroup Condition="'$(TargetFramework)' != 'net6.0'">true</PropertyGroup>

I don't know if there's a better alternative.

vitek-karas · 2024-05-10T19:45:55Z

The plan of this was to try to find a real fix for 8.0, assuming it's possible.

Ok, I see why this helps with the linux-arm case in .NET 8. It is not a generic solution for the underlying problem.

jeffschwMSFT

lgtm. we will take for consideration in 8.0.x

Remove linux-arm as supported RID for NativeAOT

b9b18ca

ivanpovazan added Servicing-consider Issue for next servicing release review area-NativeAOT-coreclr labels May 10, 2024

ivanpovazan added this to the 8.0.x milestone May 10, 2024

ivanpovazan requested review from MichalStrehovsky, agocke and vitek-karas May 10, 2024 09:54

ivanpovazan self-assigned this May 10, 2024

jkotas previously requested changes May 10, 2024

View reviewed changes

MichalStrehovsky approved these changes May 13, 2024

View reviewed changes

jeffschwMSFT approved these changes May 14, 2024

View reviewed changes

leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels May 21, 2024

leecow modified the milestones: 8.0.x, 8.0.7 May 21, 2024

ivanpovazan merged commit 44d8248 into dotnet:release/8.0-staging May 24, 2024

ivanpovazan deleted the naot-delete-unsupported-rids branch May 24, 2024 09:38

github-actions bot locked and limited conversation to collaborators Jun 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[NativeAOT] Remove `linux-arm` as a supported RID in .NET8 #102072

[NativeAOT] Remove `linux-arm` as a supported RID in .NET8 #102072

Uh oh!

ivanpovazan commented May 10, 2024

Uh oh!

dotnet-policy-service bot commented May 10, 2024

Uh oh!

ivanpovazan commented May 10, 2024

Uh oh!

jkotas left a comment

Uh oh!

jkotas May 10, 2024

Uh oh!

MichalStrehovsky May 13, 2024

Uh oh!

ivanpovazan May 13, 2024

Uh oh!

jkotas May 13, 2024

Uh oh!

ivanpovazan May 13, 2024 •

edited

Loading

Uh oh!

agocke commented May 10, 2024

Uh oh!

vitek-karas commented May 10, 2024

Uh oh!

jeffschwMSFT left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

[NativeAOT] Remove linux-arm as a supported RID in .NET8 #102072

[NativeAOT] Remove linux-arm as a supported RID in .NET8 #102072

Uh oh!

Conversation

ivanpovazan commented May 10, 2024

Customer Impact

The customer issue - mobile scenario

The internal find - desktop scenario

Regression

Testing

Risk

Uh oh!

dotnet-policy-service bot commented May 10, 2024

Uh oh!

ivanpovazan commented May 10, 2024

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

jkotas May 10, 2024

Choose a reason for hiding this comment

Uh oh!

MichalStrehovsky May 13, 2024

Choose a reason for hiding this comment

Uh oh!

ivanpovazan May 13, 2024

Choose a reason for hiding this comment

Uh oh!

jkotas May 13, 2024

Choose a reason for hiding this comment

Uh oh!

ivanpovazan May 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

agocke commented May 10, 2024

Uh oh!

vitek-karas commented May 10, 2024

Uh oh!

jeffschwMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

[NativeAOT] Remove `linux-arm` as a supported RID in .NET8 #102072

[NativeAOT] Remove `linux-arm` as a supported RID in .NET8 #102072

ivanpovazan May 13, 2024 •

edited

Loading