Fix ulong->double conversion on x64 (without avx512f) #102179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced May 14, 2024
Closed
jkotas
reviewed
May 14, 2024
Member
Author
|
/azp list |
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
/azp run runtime-coreclr outerloop, runtime-coreclr jitstress-isas-x86 |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
Author
|
@tannergooding PTAL |
tannergooding
approved these changes
May 14, 2024
Member
tannergooding
left a comment
tannergooding
left a comment
There was a problem hiding this comment.
Looks good/correct to me.
Really just a question on if doing this all in lowering vs deferring to a managed implementation that can be inlined is better.
Member
|
Potentially related regressions @EgorBo: |
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102149
Fixes #43895