Avoid MakeGenericMethod in XmlSerializer #102482
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pulled out the
IsValueTypepart of the generic method into the non-generic method since it doesn't use anything from the generic context. This should be an improvement irrespective of AOT.Then I made us take the IsValueType path if
IsDynamicCodeSupportedis false. This has two consequences:MakeGenericTypethat may or may not succeed withIsDynamicCodeSupported=falseCc @dotnet/ilc-contrib