Skip to content

Minimize System.Version formatting buffer's length #102508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Minimize System.Version formatting buffer's length #102508

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96ebd3e
Minimize System.Version formatting buffer's length
Chasmical May 21, 2024
fc03b49
Fix usage of UInt32NumberBufferLength
Chasmical May 21, 2024
4d01afb
Replace Int32NumberBufferLength with const
Chasmical May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/libraries/System.Private.CoreLib/src/System/Version.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,9 @@ public override string ToString() =>

public string ToString(int fieldCount)
{
Span<char> dest = stackalloc char[(4 * Number.Int32NumberBufferLength) + 3]; // at most 4 Int32s and 3 periods
// at most 4 non-negative Int32s and 3 periods: 2147483647.2147483647.2147483647.2147483647
const int MaximumVersionLength = 43;
Span<char> dest = stackalloc char[MaximumVersionLength];
bool success = TryFormat(dest, fieldCount, out int charsWritten);
Debug.Assert(success);
return dest.Slice(0, charsWritten).ToString();
Expand Down