[release/8.0-staging] Fix publishing PGO assets #102527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
jkoritzinsky
added
area-Infrastructure
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
ViktorHofer
approved these changes
May 21, 2024
carlossanlop
added
the
NO-MERGE
|
It was decided not to merge this at the moment to avoid resetting the runtime build. |
4 tasks
jkoritzinsky
force-pushed
the
backport/pr-92958-to-release/8.0
branch
from
117896c to
987ce19
Compare
jkoritzinsky
changed the title
|
Retargeted to staging so as to not require resetting the build (as it will only get into the next servicing build). |
jkoritzinsky
added
Servicing-consider
|
I see it's just a yaml change. Do we still need this to go through Tactics? Does this modify the shipped bits? |
4 tasks
|
This does not modify shipping bits. It only modifies non-shipping PGO bits. |
carlossanlop
added
Servicing-approved
carlossanlop
approved these changes
May 21, 2024
eduardo-vp
approved these changes
May 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #92958 to release/8.0
/cc @jkoritzinsky
Infrastructure fix for publishing PGO assets. When backporting other work for the 1ES Pipelines move, this follow-up PR was missed, which broke publishing assets from the PGO legs.
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Regressed with #102097
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
We have high confidence in this fix as the same PR provided a fix for the corresponding change in main.
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
Low risk