Skip to content

Make ObjectFactory<T> covariant #102553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 5, 2024
Merged

Make ObjectFactory<T> covariant #102553

merged 4 commits into from
Dec 5, 2024

Conversation

alrz
Copy link
Member

@alrz alrz commented May 22, 2024

Closes #101829

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 22, 2024
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection
See info in area-owners.md if you want to be subscribed.

@lilinus
Copy link
Contributor

lilinus commented May 22, 2024

I think you need to update src/libraries/Microsoft.Extensions.DependencyInjection.Abstractions/ref/Microsoft.Extensions.DependencyInjection.Abstractions.cs too?

@alrz
Copy link
Member Author

alrz commented May 22, 2024

I think you need to update src/libraries/Microsoft.Extensions.DependencyInjection.Abstractions/ref/Microsoft.Extensions.DependencyInjection.Abstractions.cs too?

Yes, thanks! I did it manually for this change though, is there a tool to regenerate refs?

@build-analysis build-analysis bot mentioned this pull request May 22, 2024
Open
@huoyaoyuan
Copy link
Member

is there a tool to regenerate refs?

See https://github.com/dotnet/runtime/blob/main/docs/coding-guidelines/updating-ref-source.md

@huoyaoyuan
Copy link
Member

The API proposal hasn't been reviewed yet. Since it's so trivial, it's a bit eager to open this PR.

@alrz
Copy link
Member Author

alrz commented May 22, 2024

The API proposal hasn't been reviewed yet.

Right, I believe this was missed the first time it was introduced, I don't mind this being left open until then though.

@buyaa-n buyaa-n added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jul 10, 2024
@ericstj ericstj requested a review from steveharter July 22, 2024 21:16
@ericstj ericstj added the blocked Issue/PR is blocked on something - see comments label Jul 22, 2024
@ericstj
Copy link
Member

ericstj commented Jul 22, 2024

This is blocked on API review

@alrz
Copy link
Member Author

alrz commented Jul 25, 2024

This is scheduled for 10.0 alongside #101889. Closing.

@alrz alrz closed this Jul 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2024
@stephentoub stephentoub reopened this Nov 24, 2024
@steveharter steveharter removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) blocked Issue/PR is blocked on something - see comments labels Dec 5, 2024
@steveharter
Copy link
Contributor

/ba-g infrastructure issue (timeout) on linux-arm64 Debug Libraries_CheckedCoreCLR

@steveharter steveharter merged commit 2300123 into dotnet:main Dec 5, 2024
74 of 82 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes

+1 more reviewer

@steveharter steveharter steveharter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Extensions-DependencyInjection community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ObjectFactory<T> delegate should be covariant

7 participants

@alrz @lilinus @huoyaoyuan @ericstj @steveharter @stephentoub @buyaa-n