Skip to content

Conversation

@am11
Copy link
Member

@am11 am11 commented May 23, 2024

No description provided.

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 23, 2024
@am11 am11 changed the title Update SDK to preview 4 Update SDK to 9.0 preview 4 May 23, 2024
@am11 am11 added area-Infrastructure community-contribution Indicates that the PR has been added by a community member and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 23, 2024
Copy link
Member

@ilonatommy ilonatommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other places with pinned versions:

@am11
Copy link
Member Author

am11 commented May 23, 2024

Sure, will update those as well. I was mainly following @MichalStrehovsky's footsteps #100945 (which made me think only to grep 9.*preview.3, find versions on the internets and replace) 😅

@am11
Copy link
Member Author

am11 commented May 23, 2024

Build wasi-wasm linux Release WasmBuildTests is failing with:

  Discovered:  Wasi.Build.Tests (found 1 of 11 test case)
  Starting:    Wasi.Build.Tests (parallel test collections = on [2 threads], stop on fail = off)
    Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [STARTING]
    Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [FAIL]
       Expected 0 exit code but got 150: /root/helix/work/workitem/e/dotnet-latest/dotnet run --no-silent --no-build -c Release
      Standard Output:
      [Release_fkeubaml_415] You must install or update .NET to run this application.
      [Release_fkeubaml_415] 
      [Release_fkeubaml_415] App: /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk/9.0.0-ci/WasmAppHost/WasmAppHost.dll
      [Release_fkeubaml_415] Architecture: x64
      [Release_fkeubaml_415] Framework: 'Microsoft.NETCore.App', version '9.0.0-preview.4.24266.19' (x64)
      [Release_fkeubaml_415] .NET location: /root/helix/work/workitem/e/dotnet-latest/
      [Release_fkeubaml_415] 
      [Release_fkeubaml_415] The following frameworks were found:
      [Release_fkeubaml_415]   8.0.7 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
      [Release_fkeubaml_415]   9.0.0-preview.4.24251.3 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
      [Release_fkeubaml_415] 
      [Release_fkeubaml_415] Learn more:
      [Release_fkeubaml_415] https://aka.ms/dotnet/app-launch-failed
      [Release_fkeubaml_415] 
      [Release_fkeubaml_415] To install missing framework, download:
      [Release_fkeubaml_415] https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=9.0.0-preview.4.24266.19&arch=x64&rid=linux-x64&os=ubuntu.22.04
      
      Stack Trace:
        /_/src/mono/wasm/Wasm.Build.Tests/Common/CommandResult.cs(44,0): at Wasm.Build.Tests.CommandResult.EnsureExitCode(Int32 expectedExitCode, String messagePrefix, Boolean suppressOutput)
        /_/src/mono/wasm/Wasm.Build.Tests/Common/CommandResult.cs(28,0): at Wasm.Build.Tests.CommandResult.EnsureSuccessful(String messagePrefix, Boolean suppressOutput)
        /_/src/mono/wasi/Wasi.Build.Tests/ILStripTests.cs(52,0): at Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(String stripILAfterAOT, Boolean expectILStripping, Boolean singleFileBundle)

@ilonatommy, is there anything else which needs to be updated before preview.1 -> preview.4 switch is possible for Wasm.Build.Tests?

@am11
Copy link
Member Author

am11 commented May 23, 2024

Build wasi-wasm linux Release WasmBuildTests is failing with:

Applied @lewing's #102624 as a patch and it fixed the error. 👏
(lets wait until that one is landed then I'll revert and merge main)

@am11 am11 force-pushed the feature/sdk-update/9.0-preview4 branch from 7dbbef4 to 2a12d10 Compare May 24, 2024 19:16
@am11
Copy link
Member Author

am11 commented May 25, 2024

@lewing looks like #100275 is back.

@am11
Copy link
Member Author

am11 commented May 27, 2024

[20:31:01] info: Using threadless Xunit runner
[20:31:01] info: Discovering: System.Security.Cryptography.Tests.dll (method display = ClassAndMethod, method display options = None)
[20:31:04] info: Discovered:  System.Security.Cryptography.Tests.dll (found 1815 of 4463 test cases)
[20:31:04] info: Starting:    System.Security.Cryptography.Tests.dll
[20:31:34] info: Finished:    System.Security.Cryptography.Tests.dll
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
....

@akoeplinger could you rerun this leg so we can find out if it's a persistent problem? In previous run it was green which is why I have this feeling. 🤞

@am11
Copy link
Member Author

am11 commented May 27, 2024

Looks green (enough) to me! :shipit:

@ViktorHofer ViktorHofer merged commit 0d0aafc into dotnet:main May 27, 2024
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
* Update SDK to preview 4

* Update BlazorClient and Shared csprojs

* Update System.Reflection.Metadata and co.

* nitpick

* Revert version update

* Remove ILCompiler workaround

* Remove crossgen2 workaround
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants