[browser] HybridGlobalization correct HashCode ranges of skipped unicodes
#102912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilonatommy
added
arch-wasm
|
Tagging subscribers to this area: @dotnet/area-system-globalization |
|
/azp run runtime-libraries-mono outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
reviewed
May 31, 2024
src/libraries/System.Private.CoreLib/src/System/Globalization/CompareInfo.WebAssembly.cs
Outdated
Show resolved
Hide resolved
pavelsavara
approved these changes
May 31, 2024
|
/azp run runtime-libraries-mono outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
matouskozak
reviewed
May 31, 2024
...ies/System.Runtime/tests/System.Globalization.Tests/CompareInfo/CompareInfoTests.HashCode.cs
Show resolved
Hide resolved
matouskozak
approved these changes
May 31, 2024
|
/ba-g issues are not related |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101912.
Revision of the issue:
Equal same & HashCode same: 0,4%
Equal different & HashCode different: 99,6%
Equal same & HashCode same: 0,4%
Equal different & HashCode different: 25,6%
Equal different & HashCode same: 74% (additional collisions that slow down the hashing algo).
OuterLoop- it's heavy and the result is expected to change rarely. This PR adds the test, removes the old, partial tests. Based on [browser]HybridGlobalizationcorrectHashCoderanges of skipped unicodes #97351 (comment).