Migrating EsrpCodeSigning Task From Version 4 to Version 5 #102948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
davfost
requested review from
a team,
jkoritzinsky,
lbussell,
missymessa and
mmitche
am11
added
area-Infrastructure
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
hoyosjs
approved these changes
Jun 1, 2024
Member
hoyosjs
left a comment
hoyosjs
left a comment
There was a problem hiding this comment.
Any test runs? Thought there's macOS issues with MI. If a test works, lgtm
Member
|
Also, how does this work given that we can't guarantee cleanup of macOS agents |
dkurepa
requested changes
Jun 3, 2024
Member
dkurepa
left a comment
dkurepa
left a comment
There was a problem hiding this comment.
Please see my comments at https://dev.azure.com/dnceng/internal/_git/dotnet-release/pullrequest/40049
dkurepa
approved these changes
Jun 24, 2024
This was referenced Jun 24, 2024
This was referenced Jun 24, 2024
hoyosjs
approved these changes
Jun 24, 2024
mmitche
approved these changes
Jun 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating EsrpCodeSigning Task From Version 4 to Version 5