Skip to content

Change tags parameter in Activity.AddException to be in parameter. #103009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2024
Merged

Change tags parameter in Activity.AddException to be in parameter. #103009

merged 1 commit into from
Jun 5, 2024

Conversation

@tarekgh
Copy link
Member

@tarekgh tarekgh commented Jun 3, 2024

No description provided.

@ghost
Copy link

ghost commented Jun 3, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Jun 3, 2024

Tagging subscribers to this area: @dotnet/area-system-diagnostics-activity
See info in area-owners.md if you want to be subscribed.

@tarekgh tarekgh requested a review from noahfalk June 3, 2024 20:59
@tarekgh
Copy link
Member Author

tarekgh commented Jun 3, 2024

CC @CodeBlanch

This was referenced Jun 3, 2024
Closed
Merged
@CodeBlanch
Copy link
Contributor

CodeBlanch commented Jun 3, 2024

LGTM

@build-analysis build-analysis bot mentioned this pull request Jun 4, 2024
Closed
This was referenced Jun 4, 2024
Closed
Open
Closed
@tarekgh
Copy link
Member Author

tarekgh commented Jun 5, 2024

/ba-g reported failures are already tracked by #102988 and #103057.

@tarekgh tarekgh merged commit a4a81ab into dotnet:main Jun 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2024
@tarekgh tarekgh deleted the MakeTagsAsInParamInActivity.AddException branch August 6, 2024 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@noahfalk noahfalk noahfalk approved these changes

Assignees

@tarekgh tarekgh

Labels

area-System.Diagnostics.Activity new-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tarekgh @CodeBlanch @noahfalk