Skip to content

Conversation

@amanasifkhalid
Copy link
Contributor

@amanasifkhalid amanasifkhalid commented Jun 4, 2024

Follow-up to #102862. This merges #92958 and #93082 into the .NET 6 servicing branch, switching over more CI build legs to the global template.

Official build

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 4, 2024
@amanasifkhalid
Copy link
Contributor Author

amanasifkhalid commented Jun 5, 2024

cc @eduardo-vp, @agocke @jkoritzinsky PTAL. Thank you! Libraries test failures are known.

@amanasifkhalid amanasifkhalid added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 5, 2024
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@amanasifkhalid
Copy link
Contributor Author

@carlossanlop @JulieLeeMSFT Jeff is OOF, could you PTAL for servicing approval? Thanks!

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Jun 5, 2024
@carlossanlop
Copy link
Contributor

carlossanlop commented Jun 5, 2024

I see this is an infra and test only change, so we can consider it tell-mode, approved.

@amanasifkhalid @eduardo-vp do we need to manually trigger any extra azp run legs? (see next comments).

@carlossanlop
Copy link
Contributor

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@JulieLeeMSFT
Copy link
Member

Approved as a tell mode.

@amanasifkhalid
Copy link
Contributor Author

Thank you for the reviews!

@amanasifkhalid @eduardo-vp do we need to manually trigger any extra azp run legs? (see next comments).

I think the modified libraries pipelines in eng/pipelines/runtime.yml were already run, and the PGO pipeline I changed in eng/pipelines/runtime-official.yml was run in the official build. So I think we're good to go?

@amanasifkhalid amanasifkhalid merged commit a48fee0 into dotnet:release/6.0-staging Jun 5, 2024
@amanasifkhalid amanasifkhalid deleted the amanasifkhalid/merge-93082 branch June 5, 2024 23:21
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants