Skip to content

Implement JsonSerializerOptions.RespectRequiredConstructorParameters #103096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 6, 2024
Merged

Implement JsonSerializerOptions.RespectRequiredConstructorParameters #103096

merged 4 commits into from
Jun 6, 2024

Conversation

@eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Jun 5, 2024

Fix #100075

@eiriktsarpalis eiriktsarpalis requested a review from jozkee June 5, 2024 21:54
@ghost
Copy link

ghost commented Jun 5, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Jun 5, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@eiriktsarpalis eiriktsarpalis self-assigned this Jun 5, 2024
@eiriktsarpalis eiriktsarpalis added this to the 9.0.0 milestone Jun 5, 2024
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Jun 5, 2024

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

eiriktsarpalis
eiriktsarpalis commented Jun 5, 2024
View reviewed changes
src/libraries/System.Text.Json/src/System/Text/Json/ThrowHelper.Serialization.cs
Debug.Assert(parent.PropertyCache != null);

// Soft cut-off length - once message becomes longer than that we won't be adding more elements
const int CutOffLength = 50;
Copy link
Member Author

@eiriktsarpalis eiriktsarpalis Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I've updated the error message so that property names are wrapped with single quotes, I'm also increasing the cutoff so that roughly speaking the same number of properties are being displayed.

@eiriktsarpalis eiriktsarpalis mentioned this pull request Jun 5, 2024
Closed
This was referenced Jun 6, 2024
Closed
Closed
Closed
Open
krwq
krwq reviewed Jun 6, 2024
View reviewed changes
krwq
krwq approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming comments are addressed

@eiriktsarpalis eiriktsarpalis merged commit d06120f into dotnet:main Jun 6, 2024
@build-analysis build-analysis bot mentioned this pull request Jun 6, 2024
Closed
This was referenced Jun 6, 2024
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jozkee jozkee jozkee left review comments

@krwq krwq krwq approved these changes

@stephentoub stephentoub Awaiting requested review from stephentoub

Assignees

@eiriktsarpalis eiriktsarpalis

Labels

area-System.Text.Json new-api-needs-documentation

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

Add a STJ feature flag treating non-optional constructor parameters as required

3 participants

@eiriktsarpalis @krwq @jozkee