Skip to content

JIT: Handle GT_JTRUE nodes during post-layout condition reversal #103319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2024
Merged

JIT: Handle GT_JTRUE nodes during post-layout condition reversal #103319

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
160ed1d
Handle GT_JTRUE nodes in optOptimizePostLayout cond reversal
amanasifkhalid Jun 11, 2024
cb4a871
Feedback
amanasifkhalid Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/coreclr/jit/optimizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2479,8 +2479,24 @@ PhaseStatus Compiler::optOptimizePostLayout()
{
GenTree* const test = block->lastNode();
assert(test->OperIsConditionalJump());
GenTree* const cond = gtReverseCond(test);
assert(cond == test); // Ensure `gtReverseCond` did not create a new node

if (test->OperIs(GT_JTRUE))
{
// Flip GT_JTRUE node's conditional operand, and handle any new nodes this may introduce
GenTree* const cond = test->gtGetOp1();
GenTree* const newCond = gtReverseCond(cond);
if (cond != newCond)
{
LIR::AsRange(block).InsertAfter(cond, newCond);
test->AsUnOp()->gtOp1 = newCond;
}
}
else
{
// gtReverseCond can handle other conditional jumps without introducing a new node
GenTree* const cond = gtReverseCond(test);
assert(cond == test);
}

FlowEdge* const oldTrueEdge = block->GetTrueEdge();
FlowEdge* const oldFalseEdge = block->GetFalseEdge();
Expand Down