Revert "Dedup UnboundedChannel and UnboundedPriorityChannel (#101396)" #103325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix has been part of the previous deduping.
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-threading-channels |
This was referenced Jun 12, 2024
Closed
adamsitnik
approved these changes
Jun 13, 2024
|
@sebastienros, once this flows, it'd be great to re-confirm this addresses the cited regression. Thanks. |
This was referenced Jun 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101936
I've not been able to figure out yet how it is that this caused the cited regression, so reverting for now. The first commit is just
git revert b4e0169bfe10cfe69f6e7a8952b8f80fdfe9e31e. The second commit is putting back a lock that should have been there initially and was fixed as part of the deduplication.