Skip to content

[browser] Use DynamicDependencyAttribute contructor friendly to InternalsVisibleTo when registering JSExports #103402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2024
Merged

[browser] Use DynamicDependencyAttribute contructor friendly to InternalsVisibleTo when registering JSExports #103402

merged 2 commits into from
Jun 13, 2024

Conversation

@maraf
Copy link
Member

@maraf maraf commented Jun 13, 2024 •
edited
Loading

Instead of using typeof(__GeneratedInitializer), use overload with string typeName and assemblyName

Fixes #103205

@maraf maraf added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Jun 13, 2024
@maraf maraf added this to the 9.0.0 milestone Jun 13, 2024
@maraf maraf self-assigned this Jun 13, 2024
This was referenced Jun 13, 2024
Closed
Closed
Closed
@maraf maraf marked this pull request as ready for review June 13, 2024 12:58
@maraf maraf requested review from lewing and pavelsavara as code owners June 13, 2024 12:58
@build-analysis build-analysis bot mentioned this pull request Jun 13, 2024
Closed
@maraf maraf merged commit f1c5823 into dotnet:main Jun 13, 2024
@maraf maraf deleted the BrowserJsExportRegistrationInternal branch June 13, 2024 20:25
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pavelsavara pavelsavara pavelsavara approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@maraf maraf

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

JSexport regression in .NET 9 SDK preview 4

2 participants

@maraf @pavelsavara