[release/8.0-staging] [mono] Fix assembly name parser to accommodate non-ASCII UTF8 strings #103475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
I'm not sure I agree this is low risk. Loader changes often have unexpected consequences. I'd say moderate risk. |
jeffschwMSFT
approved these changes
Jun 14, 2024
jkotas
changed the title
fanyang-mono
added
Servicing-approved
|
This was approved by tactics over the email. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #103363 to release/8.0
/cc @fanyang-mono
Customer Impact
Prior to this change,
Type.GetTypefails if using fully qualified assembly names where the assembly has certain international characters, when using Mono runtime.Testing
Added a new test, which passed on CI.
Manually validated the problematic maccatalyst app reported in the original issue. It works correctly now.
Risk
Moderate risk.