Skip to content

fix null check to unblock sdk #103523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 17, 2024
Merged

fix null check to unblock sdk #103523

merged 5 commits into from
Jun 17, 2024

Conversation

@kasperk81
Copy link
Contributor

dotnet/sdk#41616
regression #102152

      EFCore.Benchmarks -> /vmr/src/efcore/artifacts/bin/EFCore.Benchmarks/Release/net8.0/EFCore.Benchmarks.dll
    /vmr/src/efcore/artifacts/sb/package-cache/microsoft.extensions.hostfactoryresolver.sources/9.0.0-preview.6.24315.2/contentFiles/cs/netstandard2.0/HostFactoryResolver.cs(166,28): error CS8619: Nullability of reference types in value of type 'string?[]' doesn't match target type 'string[]'. [/vmr/src/efcore/src/EFCore.Design/EFCore.Design.csproj]
##[error]/vmr/src/efcore/artifacts/sb/package-cache/microsoft.extensions.hostfactoryresolver.sources/9.0.0-preview.6.24315.2/contentFiles/cs/netstandard2.0/HostFactoryResolver.cs(166,28): error CS8619: (NETCORE_ENGINEERING_TELEMETRY=Build) Nullability of reference types in value of type 'string?[]' doesn't match target type 'string[]'.
      EFCore.SqlServer.Benchmarks -> /vmr/src/efcore/artifacts/bin/EFCore.SqlServer.Benchmarks/Release/net8.0/EFCore.SqlServer.Benchmarks.dll

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 15, 2024
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-extensions-hosting
See info in area-owners.md if you want to be subscribed.

@kasperk81 kasperk81 mentioned this pull request Jun 15, 2024
Merged
@build-analysis build-analysis bot mentioned this pull request Jun 15, 2024
Open
@build-analysis build-analysis bot mentioned this pull request Jun 16, 2024
Closed
@kasperk81 kasperk81 requested a review from stephentoub June 16, 2024 12:02
This was referenced Jun 16, 2024
Open
Closed
@BrennanConroy BrennanConroy mentioned this pull request Jun 17, 2024
Closed
@kasperk81 kasperk81 mentioned this pull request Jun 17, 2024
Closed
buyaa-n
buyaa-n approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@MichalStrehovsky
Copy link
Member

/ba-g failures are all known and attributed by build analysis

@MichalStrehovsky
Copy link
Member

Merging to unblock codeflow to SDK repo

@MichalStrehovsky MichalStrehovsky merged commit bcd9cb8 into dotnet:main Jun 17, 2024
@kasperk81
Copy link
Contributor Author

ci run was a waste because this code doesn't even build #103553

@kasperk81 kasperk81 deleted the patch-5 branch June 17, 2024 09:28
@ericstj
Copy link
Member

ericstj commented Jun 17, 2024

It does build in tests.

@AndriySvyryd AndriySvyryd mentioned this pull request Jun 18, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub Awaiting requested review from stephentoub

1 more reviewer

@buyaa-n buyaa-n buyaa-n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Extensions-Hosting community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kasperk81 @MichalStrehovsky @ericstj @stephentoub @buyaa-n