Skip to content

Conversation

@amanasifkhalid
Copy link
Contributor

@amanasifkhalid amanasifkhalid commented Jun 24, 2024

This PR adds back jobs for building Linux installers and CrossDAC packages as part of the .NET 6 official build by surgically merging various dependent changes. There are a couple changes unrelated to this work, but otherwise needed to unblock official .NET 6 builds (like upgrading to macOS 12 images). Fixes #103485. Official build

@jkoritzinsky @agocke PTAL; thanks!

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 24, 2024
@amanasifkhalid amanasifkhalid added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 24, 2024
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@amanasifkhalid
Copy link
Contributor Author

ping @agocke @jkoritzinsky -- test failures are known. Build Analysis seems to be blocked by some infra issues that look unrelated to this change.

Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not too familiar with the crossdac build.

@agocke
Copy link
Member

agocke commented Jun 27, 2024

  • @hoyosjs in case he can provide insight on crossdac build

@amanasifkhalid amanasifkhalid requested a review from hoyosjs June 28, 2024 16:30
checkDownloadedFiles: true
- template: /eng/pipelines/common/templates/global-build-step.yml
parameters:
buildArgs: -s linuxdac+alpinedac -c $(_BuildConfig)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only thing is the xdac's used to also be uploaded to the crossDacArtifactsContainer. This is not blocking since they matter the most for PRs and they are there.

Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the installers and cross-dac artifacts in the test official build, LGTM

Copy link
Member

@JulieLeeMSFT JulieLeeMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approved. Please go ahead and merge.

@JulieLeeMSFT
Copy link
Member

CC .@carlossanlop

@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants