Skip to content

JIT: Avoid reporting call-sites in MinOpts on all targets #103950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 9, 2025
Merged

JIT: Avoid reporting call-sites in MinOpts on all targets #103950

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4c20c15
JIT: Avoid reporting call-sites in MinOpts on all targets
jakobbotsch Jun 25, 2024
fe57c11
Run jit-format
jakobbotsch Jun 25, 2024
6b70654
Merge branch 'main' of github.com:dotnet/runtime into minopts-report-…
jakobbotsch Jun 25, 2024
6f9c8aa
No tracked GC slots even when prejitting MinOpts
jakobbotsch Jun 25, 2024
550d837
Merge branch 'main' into minopts-report-call-sites
jakobbotsch Oct 28, 2024
110d72e
Merge branch 'main' into minopts-report-call-sites
jakobbotsch Oct 31, 2024
4390b5c
Force MinOpts for NAOT
jakobbotsch Nov 4, 2024
dcc02be
Merge branch 'main' of github.com:dotnet/runtime into minopts-report-…
jakobbotsch Nov 11, 2024
83fe9db
IsSafePoint -> CouldBeSafePoint
jakobbotsch Nov 11, 2024
0a2738b
Fix in Unix version too
jakobbotsch Nov 11, 2024
5408bf4
Merge branch 'main' into minopts-report-call-sites
jakobbotsch Nov 27, 2024
7a0577f
Merge branch 'main' into minopts-report-call-sites
jakobbotsch Dec 10, 2024
dea14a4
Merge branch 'main' of github.com:dotnet/runtime into minopts-report-…
jakobbotsch Jan 6, 2025
b7aa263
Revert "Force MinOpts for NAOT"
jakobbotsch Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/coreclr/jit/gcencode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4053,14 +4053,7 @@ void GCInfo::gcMakeRegPtrTable(
{
GCENCODER_WITH_LOGGING(gcInfoEncoderWithLog, gcInfoEncoder);

// TODO: Decide on whether we should enable this optimization for all
// targets: https://github.com/dotnet/runtime/issues/103917
#ifdef TARGET_XARCH
const bool noTrackedGCSlots =
compiler->opts.MinOpts() && !compiler->opts.jitFlags->IsSet(JitFlags::JIT_FLAG_PREJIT);
#else
const bool noTrackedGCSlots = false;
#endif
const bool noTrackedGCSlots = compiler->opts.MinOpts();

if (mode == MAKE_REG_PTR_MODE_ASSIGN_SLOTS)
{
Expand Down
Loading