Add bucket bound hints to Networking histograms #104629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/libraries/System.Net.Http/tests/FunctionalTests/MetricsTest.cs
|
Tagging subscribers to this area: @dotnet/ncl |
stephentoub
reviewed
Jul 9, 2024
src/libraries/System.Net.Http/src/System/Net/Http/DiagnosticsHelper.cs
Outdated
Show resolved
Hide resolved
MihaZupan
approved these changes
Jul 9, 2024
# Conflicts: # src/libraries/System.Net.Http/src/System/Net/Http/DiagnosticsHelper.cs
…v/runtime into bucket-annotations-01
This was referenced Jul 10, 2024
matouskozak
added a commit
to matouskozak/runtime
that referenced
this pull request
Jul 11, 2024
This reverts commit 5f9fff0.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104137.
HistogramBucketBoundariesis a new feature added in #63650. As described in #104137, adding support helps removing a workaround in the otel SDK, and also might help users who do not use the SDK.