ARM64-SVE: Add `FloatingPointExponentialAccelerator` #104649

amanasifkhalid · 2024-07-09T22:56:13Z

Part of #99957. I added a new test template that will probably go away soon; in #104478, I can update the fexpa tests to use the same template as the ConvertTo* APIs, and add some extra templating to wrap the API's result with the appropriate BitConverter method for the ConditionalSelect scenarios (I'm assuming the ConditionalSelect scenarios aren't testing anything interesting for this API, though).

Test output:

Starting test: .\Core_Root\corerun.exe .\HardwareIntrinsics_Arm_r\HardwareIntrinsics_Arm_r.dll Sve_FloatingPointExponentialAccelerator
===================Running default===================
------------------- {} -------------------
Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_FloatingPointExponentialAccelerator_float_uint() : 7
Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_FloatingPointExponentialAccelerator_double_ulong() : 7
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------

Starting test: .\Core_Root\corerun.exe .\HardwareIntrinsics_Arm_ro\HardwareIntrinsics_Arm_ro.dll Sve_FloatingPointExponentialAccelerator
===================Running default===================
------------------- {} -------------------
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_FloatingPointExponentialAccelerator_float_uint() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_FloatingPointExponentialAccelerator_double_ulong() : 7
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------

@dotnet/arm64-contrib PTAL, thanks!

ghost · 2024-07-09T22:56:18Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2024-07-09T22:56:20Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

amanasifkhalid · 2024-07-09T22:56:35Z

src/tests/JIT/HardwareIntrinsics/Arm/Shared/Helpers.cs

+        {
+            uint index = op1 & 0b111111;
+            uint coeff = index switch
+            {


These tables were copied from the ARM docs.

dotnet-policy-service · 2024-07-09T22:56:42Z

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

amanasifkhalid · 2024-07-10T18:35:54Z

Ah, I see we have the ConvertFunc template parameter -- I think I can get rid of the new template now...

amanasifkhalid · 2024-07-10T21:24:55Z

I tweaked the FloatingPointExponentialAccelerator tests to use the same template as the ConvertTo* APIs. The updated tests pass for both.

kunalspathak

Need to write an equivalent for double.

kunalspathak · 2024-07-11T05:29:08Z

src/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs

-                {Op1BaseType} iterResult = (mask[i] != 0) ? {GetIterResult} : falseVal[i];
-                if (iterResult != result[i])
+                {RetBaseType} iterResult = (mask[i] != 0) ? {GetIterResult} : falseVal[i];
+                if ({ConvertFunc}(iterResult) != {ConvertFunc}(result[i]))


can you please run the tests that uses the templates updated to make sure they pass?

Sure: The only template using this validation logic right now is SveSimpleVecOpDifferentRetTypeTest, which is only used by the ConvertTo* APIs (for now) and FloatingPointExponentialAccelerator. Both are passing.

src/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs

src/tests/JIT/HardwareIntrinsics/Arm/Shared/Helpers.cs

kunalspathak · 2024-07-12T15:44:33Z

src/tests/JIT/HardwareIntrinsics/Arm/Shared/Helpers.cs


+        public static double FPExponentialAccelerator(ulong op1)
+        {
+            ulong index = op1 & 0b111111;


I believe you are using N == 16 in https://docsmirror.github.io/A64/2023-06/shared_pseudocode.html#impl-aarch64.FPExpA.1?

For N=32 and N=64, the index is the first 6 bits instead of the first 5. For this helper, I got the table from the N=64 case.

kunalspathak

LGTM. Thanks!

amanasifkhalid added 2 commits July 9, 2024 18:46

Add fexpa

0b4ec09

Format

71ddae3

ghost added the area-System.Runtime.Intrinsics label Jul 9, 2024

ghost added the new-api-needs-documentation label Jul 9, 2024

dotnet-policy-service bot assigned amanasifkhalid Jul 9, 2024

amanasifkhalid commented Jul 9, 2024

View reviewed changes

amanasifkhalid mentioned this pull request Jul 9, 2024

Arm64: Implement SVE APIs #99957

Closed

amanasifkhalid added the arm-sve Work related to arm64 SVE/SVE2 support label Jul 9, 2024

This was referenced Jul 10, 2024

[Test Failure] System.Net.Security.Tests.SslStreamNetworkStreamTest.SslStream_RandomSizeWrites_OK #104605

Closed

Test failure: SslStream_RandomSizeWrites_OK #104650

Closed

Consolidate tests

c095fc0

This was referenced Jul 11, 2024

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

The job running on agent NetCore-Public ran longer than the maximum time #104044

Closed

kunalspathak suggested changes Jul 11, 2024

View reviewed changes

kunalspathak reviewed Jul 12, 2024

View reviewed changes

kunalspathak approved these changes Jul 12, 2024

View reviewed changes

amanasifkhalid merged commit 72d00a8 into dotnet:main Jul 12, 2024

amanasifkhalid deleted the sve-fexpa branch July 12, 2024 16:43

github-actions bot locked and limited conversation to collaborators Aug 12, 2024

ARM64-SVE: Add FloatingPointExponentialAccelerator #104649

ARM64-SVE: Add FloatingPointExponentialAccelerator #104649

Uh oh!

Conversation

amanasifkhalid commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jul 9, 2024

Uh oh!

ghost commented Jul 9, 2024

Uh oh!

amanasifkhalid Jul 9, 2024

Choose a reason for hiding this comment

Uh oh!

dotnet-policy-service bot commented Jul 9, 2024

Uh oh!

amanasifkhalid commented Jul 10, 2024

Uh oh!

amanasifkhalid commented Jul 10, 2024

Uh oh!

kunalspathak left a comment

Choose a reason for hiding this comment

Uh oh!

kunalspathak Jul 11, 2024

Choose a reason for hiding this comment

Uh oh!

amanasifkhalid Jul 11, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kunalspathak Jul 12, 2024

Choose a reason for hiding this comment

Uh oh!

amanasifkhalid Jul 12, 2024

Choose a reason for hiding this comment

Uh oh!

kunalspathak left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ARM64-SVE: Add `FloatingPointExponentialAccelerator` #104649

ARM64-SVE: Add `FloatingPointExponentialAccelerator` #104649

amanasifkhalid commented Jul 9, 2024 •

edited

Loading