Skip to content

ARM64-SVE: Remove new lines in System.Runtime.Intrinsics.cs (#104833) #105681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2024
Merged

ARM64-SVE: Remove new lines in System.Runtime.Intrinsics.cs (#104833) #105681

merged 1 commit into from
Jul 30, 2024

Conversation

@a74nh
Copy link
Contributor

@a74nh a74nh commented Jul 30, 2024 •
edited
Loading

There are still quite a few additional changes that need making to this file to tidy it up, but I'll put that in separate PRs to simplify the review process.

Fixes #104833

@ghost
Copy link

ghost commented Jul 30, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jul 30, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 30, 2024
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

@a74nh a74nh changed the title ARM64-SVE: Remove new lines in System.Runtime.Intrinsics.cs ARM64-SVE: Remove new lines in System.Runtime.Intrinsics.cs #104833 Jul 30, 2024
@a74nh a74nh changed the title ARM64-SVE: Remove new lines in System.Runtime.Intrinsics.cs #104833 ARM64-SVE: Remove new lines in System.Runtime.Intrinsics.cs (#104833) Jul 30, 2024
@a74nh
Copy link
Contributor Author

a74nh commented Jul 30, 2024

@dotnet/arm64-contrib @kunalspathak

@build-analysis build-analysis bot mentioned this pull request Jul 30, 2024
Closed
amanasifkhalid
amanasifkhalid approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@build-analysis build-analysis bot mentioned this pull request Jul 30, 2024
Closed
@amanasifkhalid amanasifkhalid merged commit 4a96990 into dotnet:main Jul 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@amanasifkhalid amanasifkhalid amanasifkhalid approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Runtime.Intrinsics community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JIT: SVE Cleanup - Remove newlines in System.Runtime.Intrinsics.cs

2 participants

@a74nh @amanasifkhalid