Skip to content

Fix MD5 failures on Azure Linux in System.Security.Cryptography.Pkcs #106835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Fix MD5 failures on Azure Linux in System.Security.Cryptography.Pkcs #106835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/libraries/System.Security.Cryptography.Pkcs/tests/Pkcs12/ShroudedKeyBagTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public static void BuildWithCharsFactoryReadDirect()
Assert.True(rsa2.TrySignData(
keyBag.EncryptedPkcs8PrivateKey.Span,
sig,
HashAlgorithmName.MD5,
HashAlgorithmName.SHA256,
RSASignaturePadding.Pkcs1,
out int sigLen));

Expand All @@ -49,7 +49,7 @@ public static void BuildWithCharsFactoryReadDirect()
Assert.True(rsa.VerifyData(
keyBag.EncryptedPkcs8PrivateKey.Span,
sig,
HashAlgorithmName.MD5,
HashAlgorithmName.SHA256,
RSASignaturePadding.Pkcs1));
}
}
Expand Down Expand Up @@ -77,7 +77,7 @@ public static void BuildWithBytesFactoryReadDirect()
Assert.True(rsa2.TrySignData(
keyBag.EncryptedPkcs8PrivateKey.Span,
sig,
HashAlgorithmName.MD5,
HashAlgorithmName.SHA256,
RSASignaturePadding.Pkcs1,
out int sigLen));

Expand All @@ -86,7 +86,7 @@ public static void BuildWithBytesFactoryReadDirect()
Assert.True(rsa.VerifyData(
keyBag.EncryptedPkcs8PrivateKey.Span,
sig,
HashAlgorithmName.MD5,
HashAlgorithmName.SHA256,
RSASignaturePadding.Pkcs1));
}
}
Expand Down
3 changes: 3 additions & 0 deletions src/libraries/System.Security.Cryptography.Pkcs/tests/SignatureSupport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,8 @@ public class SignatureSupport
{
public static bool SupportsRsaSha1Signatures { get; } =
System.Security.Cryptography.Tests.SignatureSupport.CanProduceSha1Signature(RSA.Create());

public static bool SupportsRsaMd5Signatures { get; } =
System.Security.Cryptography.Tests.SignatureSupport.CanProduceMd5Signature(RSA.Create());
}
}
2 changes: 1 addition & 1 deletion src/libraries/System.Security.Cryptography.Pkcs/tests/SignedCms/SignerInfoTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ public static void CheckSignature_ExtraStore_IsAdditional()
signer.CheckSignature(new X509Certificate2Collection(), true);
}

[Fact]
[ConditionalFact(typeof(SignatureSupport), nameof(SignatureSupport.SupportsRsaMd5Signatures))]
public static void CheckSignature_MD5WithRSA()
{
SignedCms cms = new SignedCms();
Expand Down