-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add TypeNameFuzzer #107206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeNameFuzzer #107206
Conversation
adamsitnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @buyaa-n !
|
Tagging subscribers to this area: @dotnet/area-system-reflection-metadata |
|
@MihuBot fuzz TypeName |
Co-authored-by: Miha Zupan <[email protected]>
|
@MihuBot fuzz TypeName |
|
|
I was able to repro the test failure: [Fact]
public void FirstBugDiscoveredByTheFuzzer()
{
const string Input = "\0[\0[][][][][][,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,][]][][][][][][]";
TypeName typeName = TypeName.Parse(Input.AsSpan());
_ = typeName.FullName;
}@buyaa-n I am going to provide a fix |
|
@MihuBot fuzz TypeName |
|
/ba-g the failure is unrelated, I need to get it merged to see if #106334 that I want to backport is going to pass fuzzing as well |
Co-authored-by: Miha Zupan <[email protected]> Co-authored-by: Adam Sitnik <[email protected]>
* AssemblyNameInfo fuzzer (#107195) * add initial AssemblyNameInfo Fuzzer * fix the first bug that it has discovered * Fix sbyte overflow in TypeName parsing (#107261) * Add TypeNameFuzzer (#107206) Co-authored-by: Miha Zupan <[email protected]> Co-authored-by: Adam Sitnik <[email protected]> * [TypeName] Nested types should respect MaxNode count (#106334) * Improve AssemblyNameInfo Fuzzer (#107257) --------- Co-authored-by: Buyaa Namnan <[email protected]> Co-authored-by: Miha Zupan <[email protected]>
Co-authored-by: Miha Zupan <[email protected]> Co-authored-by: Adam Sitnik <[email protected]>
Co-authored-by: Miha Zupan <[email protected]> Co-authored-by: Adam Sitnik <[email protected]>
Add TypeNameFuzzer with dictionary values
NOTE: Do not run Fuzzer until #107195 merged, else it will fail with same issue
Putting the PR to get feedback on dictionary and fuzzer