[release/9.0] Fix meter/instrument filtering in MetricsEventSource #107373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti |
noahfalk
approved these changes
Sep 4, 2024
tarekgh
added
area-System.Diagnostics.Metric
and removed
area-System.Diagnostics.Tracing
labels
artl93
approved these changes
Sep 5, 2024
artl93
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107267 to release/9.0
/cc @tarekgh
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Users and tools that listen to metrics data published via
MetricsEventSourceout-of-process may encounter different behavior when using an empty filter string. Currently, this filter incorrectly enables listening to all metrics instruments within the process, whereas it should listen to none. This issue was observed by an internal team who experienced performance regressions in some tests due to the unexpected activation of additional instrument listeners. This change reverts the behavior to its original state.Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
#106175
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
We have updated the tests to ensure this coverage and ran all regression tests successfully too.
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
Low, no other logic is touched, and we carefully checked the behavior and ensured it works as it used to work in .NET 8.0.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.