Skip to content

JIT: Always use edge weights to assign block weight in Compiler::fgSplitEdge #107941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2024
Merged

JIT: Always use edge weights to assign block weight in Compiler::fgSplitEdge #107941

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f9a294
Always use edge weights in fgSplitEdge
amanasifkhalid Sep 17, 2024
fba197d
Merge branch 'main' into fgSplitEdge-profile
amanasifkhalid Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions src/coreclr/jit/fgbasic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4938,23 +4938,13 @@ BasicBlock* Compiler::fgSplitEdge(BasicBlock* curr, BasicBlock* succ)

// Set weight for newBlock
//
if (curr->KindIs(BBJ_ALWAYS))
{
newBlock->inheritWeight(curr);
}
else
FlowEdge* const currNewEdge = fgGetPredForBlock(newBlock, curr);
newBlock->bbWeight = currNewEdge->getLikelyWeight();
newBlock->CopyFlags(curr, BBF_PROF_WEIGHT);

if (newBlock->bbWeight == BB_ZERO_WEIGHT)
{
if (curr->hasProfileWeight())
{
FlowEdge* const currNewEdge = fgGetPredForBlock(newBlock, curr);
newBlock->setBBProfileWeight(currNewEdge->getLikelyWeight());
}
else
{
// Todo: use likelihood even w/o profile?
//
newBlock->inheritWeightPercentage(curr, 50);
}
newBlock->bbSetRunRarely();
}

// The bbLiveIn and bbLiveOut are both equal to the bbLiveIn of 'succ'
Expand Down