Skip to content

Use Unsafe.BitCast for generic span casting #109136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Use Unsafe.BitCast for generic span casting #109136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
29b55bd
Use `Unsafe.BitCast` for generic span casting
xtqqczze Oct 23, 2024
f488388
Update `Enum.EnumInfo`
xtqqczze Oct 24, 2024
23eb66a
Merge branch 'main' into UnsafeBitCast
xtqqczze Nov 20, 2024
f665d84
Merge branch 'main' into UnsafeBitCast
xtqqczze Nov 24, 2024
234b6a5
Merge branch 'main' into UnsafeBitCast
xtqqczze Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/libraries/System.Private.CoreLib/src/System/Enum.EnumInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

using System.Diagnostics;
using System.Numerics;
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;

namespace System
Expand Down Expand Up @@ -36,7 +37,7 @@ public EnumInfo(bool hasFlagsAttribute, TStorage[] values, string[] names)
public unsafe TResult[] CloneValues<TResult>() where TResult : struct
{
Debug.Assert(sizeof(TStorage) == sizeof(TResult));
return MemoryMarshal.Cast<TStorage, TResult>(Values).ToArray();
return Unsafe.BitCast<ReadOnlySpan<TStorage>, ReadOnlySpan<TResult>>(Values).ToArray();
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/System/Globalization/DateTimeFormat.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,7 @@ internal static void AppendChar<TChar>(ref ValueListBuilder<TChar> result, char
{
Debug.Assert(typeof(TChar) == typeof(byte));
var r = new Rune(ch);
r.EncodeToUtf8(MemoryMarshal.AsBytes(result.AppendSpan(r.Utf8SequenceLength)));
r.EncodeToUtf8(Unsafe.BitCast<Span<TChar>, Span<byte>>(result.AppendSpan(r.Utf8SequenceLength)));
}
}

Expand Down
3 changes: 2 additions & 1 deletion src/libraries/System.Private.CoreLib/src/System/Globalization/HebrewNumber.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System.Collections.Generic;
using System.Diagnostics;
using System.Numerics;
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;
using System.Text;

Expand Down Expand Up @@ -211,7 +212,7 @@ internal static void Append<TChar>(ref ValueListBuilder<TChar> outputBuffer, int
else
{
Debug.Assert(typeof(TChar) == typeof(byte));
Rune.DecodeLastFromUtf8(MemoryMarshal.AsBytes(outputBuffer.AsSpan()), out Rune value, out int bytesConsumed);
Rune.DecodeLastFromUtf8(Unsafe.BitCast<ReadOnlySpan<TChar>, ReadOnlySpan<byte>>(outputBuffer.AsSpan()), out Rune value, out int bytesConsumed);
outputBuffer.Length -= bytesConsumed;
outputBuffer.Append(TChar.CastFrom('"'));
DateTimeFormat.AppendChar(ref outputBuffer, (char)value.Value);
Expand Down
Loading