[cdac] Handle non-default active version and explicit IL code version cases for CodeVersions.GetActiveNativeCodeVersion
#109560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for CodeVersions.GetActiveNativeCodeVersion
elinor-fung
requested review from
AaronRobinsonMSFT,
davidwrighton and
max-charlamb
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
11 tasks
3 tasks
elinor-fung
commented
Nov 7, 2024
| (nameof(Data.NativeCodeVersionNode.MethodDesc), DataType.pointer), | ||
| (nameof(Data.NativeCodeVersionNode.NativeCode), DataType.pointer), | ||
| (nameof(Data.NativeCodeVersionNode.Flags), DataType.uint32), | ||
| (nameof(Data.NativeCodeVersionNode.ILVersionId), DataType.nuint), |
There was a problem hiding this comment.
In a separate change, I'm planning on pulling out these arrays of fields into MockDescriptors (and probably breaking that apart a bit) - like we have for other fields.
AaronRobinsonMSFT
approved these changes
Nov 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeVersions.GetActiveNativeCodeVersionto handle non-default active version and explicit IL code versionRuntimeTypeSystem.GetAddressOfSlotto handle non-virtual slotsMethodDescCodeDatainRuntimeTypeSystem.GetMethodDescVersioningStateContributes to #99302, #109426