Skip to content

Conversation

@gewarren
Copy link
Contributor

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 14, 2024
@gewarren gewarren marked this pull request as ready for review November 14, 2024 03:51
@carlossanlop
Copy link
Contributor

Apparently one xml failure will hide all other failures that follow it, and they don't show up until you fix the first one. Right?

In that case, may I give a suggestion? You can build the whole repo locally (once), and after that just build the individual project that you're testing. That way you don't have to wait until the whole CI finishes to know what to fix next.

  1. Full build, just once: .\build.cmd clr+libs
  2. Make your xml changes
  3. Do project builds from now on:
.\dotnet.cmd build .\src\libraries\Microsoft.Extensions.DependencyInjection\src\Microsoft.Extensions.DependencyInjection.csproj

@gewarren
Copy link
Contributor Author

@carlossanlop If you approve, I think we can merge this.

@carlossanlop
Copy link
Contributor

/ba-g One failure unrelated to this change. The other was a machine that rebooted mid execution.

@carlossanlop carlossanlop merged commit f3cdf14 into dotnet:main Nov 18, 2024
9 checks passed
@carlossanlop
Copy link
Contributor

If this applies to 9.0, we can backport. Agreed?

mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
* docs updates

* a couple more updates

* fix cref

* try to fix crefs

* try to fix crefs

* try again

* one more try

* try one more thing
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants