JIT: (x u>> cns) -> [0..(x's max value >> cns)] #109900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
Co-authored-by: Theodore Tsirpanis <[email protected]>
This was referenced Nov 17, 2024
|
PTAL @AndyAyersMS @dotnet/jit-contrib a change to optimize bounds check for "arr[X >> CNS]" pattern in order to remove unsafe code from the repo |
AndyAyersMS
approved these changes
Nov 18, 2024
| return Range(Limit(Limit::keConstant, 0)); | ||
| } | ||
|
|
||
| // Calculate max possible value of op1, e.g. UINT_MAX for TYP_INT/TYP_UINT |
There was a problem hiding this comment.
Was wondering if we could use IntegralRange here but that seems a bit clunky.
There was a problem hiding this comment.
Initially, I wanted to call RangeCheck::ComputeRange on op1 to get even more precise range, but it had no diffs
Open
3 tasks
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes bounds check for #109899