Ensure that we don't try and optimize masks for promoted fields #110485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
CC. @jakobbotsch |
This was referenced Dec 6, 2024
|
CC. @dotnet/jit-contrib This fixes #110326 and the issue found by antigen for the new optimization. The optimization had initially been enabled only for Arm64 which requires an SVE capable machine and explicit opt-in for the JIT to execute the code paths; enabling it for x64 where AVX512 is on by default for CI machines has allowed such edge cases to more readily surface. |
|
ping @dotnet/jit-contrib, @jakobbotsch for review; this resolves #110326 |
jakobbotsch
approved these changes
Dec 11, 2024
hez2010
pushed a commit
to hez2010/runtime
that referenced
this pull request
Dec 14, 2024
…et#110485) * Ensure that we don't try and optimize masks for promoted fields * Add using for Xunit * Fix test name * Make the xunit analyzer happy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #110326