Skip to content

Support writing base64 JSON segments #111041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 14, 2025
Merged

Support writing base64 JSON segments #111041

merged 3 commits into from
Jan 14, 2025

Conversation

@PranavSenthilnathan
Copy link
Member

Adds support to the Utf8JsonWriter for writing string value segments of byte[] encoded as Base64 UTF-8.

Closes #67337

@ghost
Copy link

ghost commented Jan 2, 2025

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Jan 2, 2025

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Copilot
Copilot AI reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

This was referenced Jan 3, 2025
Open
Open
Closed
Closed
@PranavSenthilnathan PranavSenthilnathan mentioned this pull request Jan 4, 2025
Closed
@eiriktsarpalis eiriktsarpalis mentioned this pull request Jan 14, 2025
Merged
eiriktsarpalis
eiriktsarpalis reviewed Jan 14, 2025
View reviewed changes
src/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.cs
{
get
{
Debug.Assert(PreviousSegmentEncoding == SegmentEncoding.Utf8);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing PreviousSegmentEncoding would eventually be replaced by "enclosing container" data as introduced in #111332

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That PR doesn't do it but it could in order to avoid the bit twiddling that PreviousSegmentEncoding currently does.

@PranavSenthilnathan
Copy link
Member Author

/ba-g There are known infrastructure errors and test errors. The other build failure was an unrelated timeout affecting other PRs.

@build-analysis build-analysis bot mentioned this pull request Jan 14, 2025
Closed
@PranavSenthilnathan PranavSenthilnathan merged commit 2bfe21b into dotnet:main Jan 14, 2025
78 of 82 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

Assignees

@PranavSenthilnathan PranavSenthilnathan

Labels

area-System.Text.Json new-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add ability to stream large strings in Utf8JsonWriter/Utf8JsonReader

2 participants

@PranavSenthilnathan @eiriktsarpalis