Remove RequiresProcessIsolation from HFA tests
#111406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests using `CMakeProjectReference` seem to work just fine with the merged runner.
Before (CoreCLR, checked, Ryzen 9700X):
```
Time [secs] | Total | Passed | Failed | Skipped | Assembly Execution Summary
============================================================================
47.303 | 112 | 112 | 0 | 0 | JIT.jit64.jit64_1
```
After:
```
Time [secs] | Total | Passed | Failed | Skipped | Assembly Execution Summary
============================================================================
2.694 | 112 | 112 | 0 | 0 | JIT.jit64.jit64_1
```
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
EgorBo
approved these changes
Jan 14, 2025
jkoritzinsky
approved these changes
Jan 14, 2025
Nope, these all look the same (a couple project references and settings related to opt/debug info and that's it). |
MichalStrehovsky
added a commit
to MichalStrehovsky/runtime
that referenced
this pull request
Jan 28, 2025
As per dotnet#111406, `RequiresProcessIsolation` is not needed just because of `CMakeProjectReference`. The tests also have `CLRTestTargetUnsupported`, but all of them do, so I just moved it to the merged runner. (Note, mcc_i00 didn't have CLRTestTargetUnsupported to make it Windows only, but instead we had it in issues.targets as `needs triage`, so deleting that.) Before (CoreCLR checked, Microsoft DevBox): ``` Time [secs] | Total | Passed | Failed | Skipped | Assembly Execution Summary ============================================================================ 74.311 | 56 | 56 | 0 | 0 | JIT.jit64.jit64_2 ``` After: ``` Time [secs] | Total | Passed | Failed | Skipped | Assembly Execution Summary ============================================================================ 2.088 | 56 | 56 | 0 | 0 | JIT.jit64.jit64_2 ```
MichalStrehovsky
added a commit
that referenced
this pull request
Jan 28, 2025
As per #111406, `RequiresProcessIsolation` is not needed just because of `CMakeProjectReference`. The tests also have `CLRTestTargetUnsupported`, but all of them do, so I just moved it to the merged runner. (Note, mcc_i00 didn't have CLRTestTargetUnsupported to make it Windows only, but instead we had it in issues.targets as `needs triage`, so deleting that.) Before (CoreCLR checked, Microsoft DevBox): ``` Time [secs] | Total | Passed | Failed | Skipped | Assembly Execution Summary ============================================================================ 74.311 | 56 | 56 | 0 | 0 | JIT.jit64.jit64_2 ``` After: ``` Time [secs] | Total | Passed | Failed | Skipped | Assembly Execution Summary ============================================================================ 2.088 | 56 | 56 | 0 | 0 | JIT.jit64.jit64_2 ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests using
CMakeProjectReferenceseem to work just fine with the merged runner.Before (CoreCLR, checked, Ryzen 9700X):
After:
Cc @dotnet/jit-contrib @jkoritzinsky