arm64: Add tests for add(s), and(s), sub(s), cmp, cmn, eor, neg & orr #111796
Conversation
ghost
added
the
area-CodeGen-coreclr
|
@a74nh @kunalspathak @dotnet/arm64-contrib |
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
kunalspathak
left a comment
kunalspathak
left a comment
There was a problem hiding this comment.
Thanks for adding the test coverage. Added some follow up questions.
| static bool CmnLSR(uint a, uint b) | ||
| { | ||
| //ARM64-FULL-LINE: lsr {{w[0-9]+}}, {{w[0-9]+}}, #2 | ||
| //ARM64-FULL-LINE: cmn {{w[0-9]+}}, {{w[0-9]+}} |
There was a problem hiding this comment.
can we open an issue for this? According to #68028, "shifted register" should already be in place.
There was a problem hiding this comment.
Do we know why it doesn't kick in?
| { | ||
| //ARM64-FULL-LINE: lsl {{x[0-9]+}}, {{x[0-9]+}}, #55 | ||
| //ARM64-FULL-LINE: cmp {{x[0-9]+}}, {{x[0-9]+}} | ||
| if (a == (b<<119)) |
There was a problem hiding this comment.
are we having two instructions here because the constant doesn't fit in imm6 of cmp?
| static int EorLSL(int a, int b) | ||
| { | ||
| //ARM64-FULL-LINE: eor {{w[0-9]+}}, {{w[0-9]+}}, {{w[0-9]+}}, LSL #4 | ||
| return a ^ (b<<4); |
There was a problem hiding this comment.
can you add some test for (b << 4) ^ a?
There was a problem hiding this comment.
similar for other commutative operations?
There was a problem hiding this comment.
Added tests with operands in opposite order.
| { | ||
| //ARM64-FULL-LINE: lsr {{w[0-9]+}}, {{w[0-9]+}}, #20 | ||
| //ARM64-FULL-LINE: neg {{w[0-9]+}}, {{w[0-9]+}} | ||
| return (uint)-(a>>20); |
There was a problem hiding this comment.
do we know why we generate 2 instructios here?
2 participants
No description provided.