Improve docs on building ILVerify #111851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kant2002
commented
Jan 27, 2025
kant2002
commented
- Much faster to build now, less deps
- Fix names of the projects
- Fix instruction for running tests based on latest changes in the test infra, have funny error on Windows when use Linux style slashes. Would like to fix this in CoreRun if possible.
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
jkotas
reviewed
Jan 27, 2025
src/coreclr/tools/ILVerify/README.md
Outdated
| src/tests/build.(cmd/sh) release -priority=1 | ||
| ``` | ||
|
|
||
| or significantly faster use only |
There was a problem hiding this comment.
The existing instructions can be deleted. I guess they were written before the test build had tree option.
jkotas
reviewed
Jan 27, 2025
src/coreclr/tools/ILVerify/README.md
Outdated
|
|
||
| As quick snippet which should be enough to build CoreCLR | ||
| ``` | ||
| ./build.cmd -s clr.native+clr.corelib+clr.tools+clr.nativecorelib+libs -c release |
There was a problem hiding this comment.
Is this significantly better than just -s clr+libs?
jkotas
reviewed
Jan 27, 2025
jkotas
reviewed
Jan 27, 2025
Co-authored-by: Jan Kotas <[email protected]>
Co-authored-by: Jan Kotas <[email protected]>
jkotas
reviewed
Jan 27, 2025
jkotas
reviewed
Jan 27, 2025
jkotas
reviewed
Jan 28, 2025
jkotas
approved these changes
Jan 28, 2025
grendello
added a commit
to grendello/runtime
that referenced
this pull request
Jan 28, 2025
* main: (31 commits) Fix linux-x86 build (dotnet#111861) Add FrozenDictionary specialization for integers / enums (dotnet#111886) [SRM] Refactor reading from streams. (dotnet#111323) Sign the DAC and DBI during the build process instead of in separate steps (dotnet#111416) Removing Entry2MethodDesc as it is unnecessary (dotnet#111756) Cross Product for Vector2 and Vector4 (dotnet#111265) Handle unicode in absolute URI path for combine. (dotnet#111710) Drop RequiresProcessIsolation on mcc tests (dotnet#111887) [main] Update dependencies from dotnet/roslyn (dotnet#111691) new trimmer feature System.TimeZoneInfo.Invariant (dotnet#111215) [browser] reduce msbuild memory footprint (dotnet#111751) Add debugging checks for stack overflow tests failure (dotnet#111867) Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2629821 (dotnet#111884) Bump main to preview2 (dotnet#111882) Avoid generic virtual dispatch for frozen collections alternate lookup (dotnet#108732) Bump main versioning to preview1 (dotnet#111880) Switch OneLoc to main (dotnet#111872) Improve docs on building ILVerify (dotnet#111851) Update Debian version to 13 (dotnet#111768) win32: add fallback to environment vars for system folder (dotnet#109673) ...
jkotas
added
area-Tools-ILVerification
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.