Skip to content

Split effects #111896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 57 commits into from
Closed

Split effects #111896

wants to merge 57 commits into from

Conversation

@hez2010
Copy link
Contributor

@hez2010 hez2010 commented Jan 28, 2025

No description provided.

hez2010 added 30 commits January 21, 2025 03:41
@hez2010
Enable inlining for late devirt
686f64e
@hez2010
Pass correct IL offset
27cc1ce
@hez2010
Only creates RET_EXPR if the node is not top-level or not returning void
21a5adb
@hez2010
Do not try inlining if BBF_INTERNAL is set
d1d5181
@hez2010
Ensure the type matches
cd9f817
@hez2010
Set inliner context correctly
aad3d7e
@hez2010
Merge branch 'main' into inline-exact-devirt
3f5204b
@hez2010
Address review feedbacks
3b5b446
@hez2010
Fix non inline candidate marking
27bc0aa
@hez2010
Handle calls with retbuf
dbf204a
@hez2010
Handle BBF_INTERNAL
f6d38c4
@hez2010
Get real type from local
10de97b
@hez2010
Always set IL offset
472e140
@hez2010
Add comments
20b1a94
@hez2010
Oops
5c9c927
@hez2010
Use gtReturnType instead
97326e2
@hez2010
Remove unused ilOffset
096ab2a
@hez2010
Use genActualType
095a981
@hez2010
Merge branch 'main' into inline-exact-devirt
614618a
@hez2010
Remove unnecessary spillTemp
5951462
@hez2010
Handle nested call correctly
03c0df5
@hez2010
Don't promote compCurStmt
0042519
@hez2010
Merge branch 'main' into inline-exact-devirt
b35d1ba
@hez2010
Remove unused ilOffset
0e13553
@hez2010
Handle BBF_INTERNAL
edfa2ac
@hez2010
Use correct return type
d40d7e1
@hez2010
Use bbInCatchHandlerBBRange and bbInFilterBBRange
e540cac
@hez2010
Cleanup fncRetType
036010c
@hez2010
Add a runtime check to prevent accidental execution order change
121242e
@hez2010
Merge remote-tracking branch 'hez2010/inline-exact-devirt-prelim' int…
0b7ada3 
…o inline-exact-devirt
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 28, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 28, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Jan 28, 2025

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

jakobbotsch
jakobbotsch reviewed Jan 28, 2025
View reviewed changes
@hez2010 hez2010 mentioned this pull request Jan 28, 2025
Merged
@hez2010
Copy link
Contributor Author

hez2010 commented Jan 28, 2025

@MihuBot

@MihuBot MihuBot mentioned this pull request Jan 28, 2025
Open
@hez2010 hez2010 closed this Jan 28, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotsch jakobbotsch jakobbotsch left review comments

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hez2010 @jakobbotsch