Skip to content

Conversation

mrvoorhe
Copy link
Contributor

I missed a few places with

	[SetupLinkerKeepDebugMembers ("true")]

back when I landed #89011

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 11, 2025
@mrvoorhe
Copy link
Contributor Author

@sbomer Please take a look

Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mrvoorhe
Copy link
Contributor Author

/ba-g "Unrelated timeouts"

I missed a few places with
```
	[SetupLinkerKeepDebugMembers ("true")]
```

back when I landed dotnet#89011
@mrvoorhe
Copy link
Contributor Author

@sbomer Can you merge the PR?

@sbomer sbomer merged commit e30fd97 into dotnet:main Feb 19, 2025
74 of 77 checks passed
grendello pushed a commit to grendello/runtime that referenced this pull request Feb 19, 2025
I missed a few places with
```
	[SetupLinkerKeepDebugMembers ("true")]
```

back when I landed dotnet#89011
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community-contribution Indicates that the PR has been added by a community member linkable-framework Issues associated with delivering a linker friendly framework needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants