Add test that AppContext.BaseDirectory is rooted #113232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
There was a problem hiding this comment.
PR Overview
This PR adds a new test to verify that AppContext.BaseDirectory returns a rooted path.
- Added using System.IO to support path operations.
- Introduced the BaseDirectory_PathRooted test method to assert that AppContext.BaseDirectory is rooted.
Reviewed Changes
| File | Description |
|---|---|
| src/libraries/System.Runtime/tests/System.Runtime.Tests/System/AppContext/AppContextTests.cs | Added new test for ensuring AppContext.BaseDirectory is a rooted path |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
jkoritzinsky
approved these changes
Mar 6, 2025
This was referenced Mar 7, 2025
This was referenced Mar 10, 2025
|
Is rooted enough? Shouldn't this check for fully absolute for Windows cases? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.