Reduce TP for targets with more than 64 Registers Part 2 : Make operations on fixedRegs less expensive #113713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
DeepakRajendrakumaran
force-pushed
the
killreg
branch
2 times, most recently
from
df9d60f to
a91ef0b
Compare
DeepakRajendrakumaran
force-pushed
the
killreg
branch
2 times, most recently
from
56dc88c to
134eea5
Compare
DeepakRajendrakumaran
changed the title
This was referenced Mar 24, 2025
DeepakRajendrakumaran
force-pushed
the
killreg
branch
2 times, most recently
from
030b684 to
d2b16f9
Compare
DeepakRajendrakumaran
force-pushed
the
killreg
branch
from
d2b16f9 to
6db2ad5
Compare
This was referenced Mar 25, 2025
DeepakRajendrakumaran
force-pushed
the
killreg
branch
2 times, most recently
from
97ea8dd to
477aa53
Compare
This was referenced Mar 26, 2025
Open
DeepakRajendrakumaran
force-pushed
the
killreg
branch
from
477aa53 to
dc1d20a
Compare
DeepakRajendrakumaran
changed the title
|
@BruceForstall @kunalspathak This PR is ready for review. |
|
odd superpmi-replay failure. trying again. /azp run runtime-coreclr superpmi-replay |
|
/azp run runtime-coreclr superpmi-replay |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kunalspathak
approved these changes
Mar 27, 2025
|
/ba-g failures are timeout |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The reason why
updateNextFixedRefis expensive is due to us repeatedly working onfixedRegswhich is aregMaskTP. This change splitsfixedRegsinto 2SingleTypeRegSetvariablesfixedRegsLowandfixedRegsHigh. This necessitates some changes to how we call the impacted methods. ImplementingupdateNextFixedRefas a templated method allows us to have 2 separate versions of this method without adding duplicate methodsChanges included here
fixedRegsis split into 2 separateSingleTypeRegSeton targets with more than 64 registersupdateNextFixedRefimplementation that works on the newly createdSingleTypeRegSetupdateNextFixedRefDispatchwhich calls the requiredupdateNextFixedRefbased on register number.Impact of this change
This change should have minimal to no impact on targets with less than 64 registers. Local testing done with additional eGPR enabled(to simulate more than 64 registers) show the following results
Overall (-0.35% to -0.12%)
MinOpts (-1.09% to -0.31%)
FullOpts (-0.32% to -0.12%)
Will help with reducing regression in 'procesKills()` - #112962