Skip to content

Conversation

@trungnt2910
Copy link
Contributor

Adds detection for non-portable filesystem and mount APIs and equivalent implementations using the Haiku API.

Part of #55803.

Copilot AI review requested due to automatic review settings April 11, 2025 02:55
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 11, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 11, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • src/native/libs/Common/pal_config.h.in: Language not supported
  • src/native/libs/configure.cmake: Language not supported
Comments suppressed due to low confidence (1)

src/native/libs/System.Native/pal_mount.c:28

  • [nitpick] Consider standardizing the Haiku platform macro naming across the codebase (e.g., using TARGET_HAIKU uniformly instead of mixing HAIKU and TARGET_HAIKU).
#ifdef __HAIKU__

@trungnt2910 trungnt2910 force-pushed the dev/trungnt2910/haiku-native-libs-io branch from 4bedc18 to 0b60e41 Compare April 11, 2025 03:02
@jkotas jkotas added area-System.IO and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 11, 2025
Adds detection for non-portable filesystem and mount APIs and
equivalent implementations using the Haiku API.
@trungnt2910 trungnt2910 force-pushed the dev/trungnt2910/haiku-native-libs-io branch from 0862fad to 473aa80 Compare April 11, 2025 14:06
@am11 am11 added the os-haiku label Apr 11, 2025
@trungnt2910
Copy link
Contributor Author

Anything I can do to move this PR forward?

@jeffhandley
Copy link
Member

@trungnt2910 I'm sorry we sat on this as long as we did. If you can address the merge conflict that have arisen, we will review it for it to get merged into .NET 11. Thanks.

@jozkee jozkee added the needs-author-action An issue or pull request that requires more info or actions from the author. label Sep 15, 2025
@trungnt2910
Copy link
Contributor Author

Still tracking this, haven't got the time to rebase though, sorry.
I will get back to this later this year.

@dotnet-policy-service dotnet-policy-service bot removed needs-author-action An issue or pull request that requires more info or actions from the author. no-recent-activity labels Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.IO community-contribution Indicates that the PR has been added by a community member os-haiku

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants