Skip to content

Replace compiler specific options with C++ thread_local keyword #114660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 19, 2025
Merged

Replace compiler specific options with C++ thread_local keyword #114660

merged 5 commits into from
Apr 19, 2025

Conversation

@AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented Apr 14, 2025

Rename gCurrentThreadInfo to t_CurrentThreadInfo to align with the naming convention.

@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 10.0.0 milestone Apr 14, 2025
@AaronRobinsonMSFT
Copy link
Member Author

AaronRobinsonMSFT commented Apr 14, 2025

/cc @jkotas @janvorli

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Apr 14, 2025

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member

jkotas commented Apr 15, 2025

Build breaks look related:

 _t_ThreadStatics, referenced from:
        _GetThreadVarsAddress in asmhelpers.S.o
        _GetThreadVarsAddress in asmhelpers.S.o

jkotas
jkotas reviewed Apr 15, 2025
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Apr 15, 2025
Open
3 tasks
@AaronRobinsonMSFT AaronRobinsonMSFT marked this pull request as ready for review April 15, 2025 18:58
@build-analysis build-analysis bot mentioned this pull request Apr 15, 2025
Open
3 tasks
jkotas
jkotas approved these changes Apr 16, 2025
View reviewed changes
@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 55b8f9f into dotnet:main Apr 19, 2025
93 of 95 checks passed
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the thread_local_pal branch April 19, 2025 03:42
This was referenced Apr 24, 2025
Closed
Closed
Closed
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas approved these changes

Assignees

@AaronRobinsonMSFT AaronRobinsonMSFT

Labels

area-VM-coreclr

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@AaronRobinsonMSFT @jkotas