Skip to content

Exclude PMI collection of Dia2Lib.dll to work around #114933 #114936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Exclude PMI collection of Dia2Lib.dll to work around #114933 #114936

wants to merge 1 commit into from

Conversation

@BruceForstall
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 22, 2025 23:09
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 22, 2025
Copilot AI reviewed Apr 22, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR excludes Dia2Lib.dll from the PMI collection process to work around issue #114933.

  • Added "Dia2Lib.dll" with an explanatory comment in the file list in superpmi_collect_setup.py.

@BruceForstall
Copy link
Contributor Author

@dotnet/jit-contrib PTAL

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@BruceForstall
Copy link
Contributor Author

Not needed after #115009

@BruceForstall BruceForstall deleted the WorkAround114933 branch April 25, 2025 17:54
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@kunalspathak kunalspathak Awaiting requested review from kunalspathak

Assignees

@BruceForstall BruceForstall

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@BruceForstall