Fix ReadContentAsDateTime method to keep DateTimeKind #114969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #114813 by updating the ReadContentAsDateTime method to preserve the DateTimeKind, aligning its behavior with the framework's implementation.
- Updated ReadContentAsDateTime to directly call InnerReader.ReadContentAsDateTime() instead of extracting the DateTime from a DateTimeOffset.
- Ensured consistency with the framework's implementation as referenced in the description.
dotnet-policy-service
bot
added
the
community-contribution
This was referenced Apr 23, 2025
lilinus
reviewed
Apr 30, 2025
....Private.DataContractSerialization/src/System/Runtime/Serialization/XmlSerializableReader.cs
Show resolved
Hide resolved
BradBarnich
force-pushed
the
xml-keep-datetime-kind
branch
from
419a6c7 to
3f99553
Compare
BradBarnich
force-pushed
the
xml-keep-datetime-kind
branch
from
3f99553 to
818d29c
Compare
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17871050411 |
4 tasks
xtqqczze
pushed a commit
to xtqqczze/dotnet-runtime
that referenced
this pull request
Sep 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
potential fix for #114813
roundtripping through DateTimeOffset.DateTime loses the DateTimeKind, which in some code paths causes incorrect interpretation in DateTimeOffsetAdapter
this is also what the code looks like in framework: https://github.com/microsoft/referencesource/blob/master/System.Runtime.Serialization/System/Runtime/Serialization/XmlSerializableReader.cs#L117