Skip to content

Run outerloop pipeline only for release branches, not staging/preview #114971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

Run outerloop pipeline only for release branches, not staging/preview #114971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eng/pipelines/libraries/outerloop-mono.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ schedules:
branches:
include:
- main
always: false # run only if there were changes since the last successful scheduled run.

variables:
- template: variables.yml
Expand Down
3 changes: 2 additions & 1 deletion eng/pipelines/libraries/outerloop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ schedules:
branches:
include:
- main
- release/*.*
- release/*.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -staging variants might be more useful as they get active changes. Granted - neither release branch gets a lot of scrutiny.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I don't have a strong opinion. My thinking was that since they don't get a lot of scrutiny anyway (they've been red forever) it'd be better to save more reasources by only running on the .0 branches which change less often.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the always change is really the more important of the two here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we ever decide to once again release a version like 3.1, this filter won't apply. Shouldn't it just be release/*?

Copy link
Member Author

@akoeplinger akoeplinger Apr 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlossanlop no since that one will match the preview/staging branches again. if we ever go back to .1 then lots of other stuff will break, this is the least of my concerns :)

always: false # run only if there were changes since the last successful scheduled run.

variables:
- template: variables.yml
Expand Down
Loading