Fix SLH-DSA key to use SHA-1 MAC for Windows support #115271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Updates the PKCS#12 test fixture to use a SHA-1 MAC for Windows compatibility, replacing the previous SHA-256 MAC–encoded blob.
- Replaces the base64 PFX data for
IetfSlhDsaSha2_128sCertificatePfx_Pbes1with a new blob using SHA-1 MAC. - Ensures Windows 10 Threshold can import the test PFX.
Comments suppressed due to low confidence (1)
src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaTestData.cs:385
- There’s no test that validates the MAC algorithm on the new PFX blob. Consider adding a test that loads this PFX and asserts its MAC OID is the SHA-1 OID (1.3.14.3.2.26) to prevent regressions.
internal static byte[] IetfSlhDsaSha2_128sCertificatePfx_Pbes1 => field ??= Convert.FromBase64String(@"
|
@bartonjs @PranavSenthilnathan something dead lettered? Can this be ba-g'ed? |
|
/ba-g This test doesn't even run on wasm. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PKCS#12 document in
IetfSlhDsaSha2_128sCertificatePfx_Pbes1usedpbeWithSHA1And3-KeyTripleDES-CBCfor key and certificate encryption, but it still used SHA-256 for the MAC, which Windows 10 Threshold does not support. This pull request re-encodes it to use a SHA-1 MAC.Contributes to #115270 (not marking as fixing until Build Analysis shows a 0 24-hour hit count)